Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755222AbaGIIqr (ORCPT ); Wed, 9 Jul 2014 04:46:47 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:59389 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752781AbaGIIqp (ORCPT ); Wed, 9 Jul 2014 04:46:45 -0400 Date: Wed, 9 Jul 2014 01:46:44 -0700 From: Christoph Hellwig To: "K. Y. Srinivasan" Cc: linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, ohering@suse.com, jbottomley@parallels.com, jasowang@redhat.com, apw@canonical.com, linux-scsi@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 8/8] drivers: scsi: storvsc: Correctly handle TEST_UNIT_READY failure Message-ID: <20140709084644.GH6012@infradead.org> References: <1404866789-26910-1-git-send-email-kys@microsoft.com> <1404866812-26950-1-git-send-email-kys@microsoft.com> <1404866812-26950-8-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404866812-26950-8-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 08, 2014 at 05:46:52PM -0700, K. Y. Srinivasan wrote: > --- a/drivers/scsi/storvsc_drv.c > +++ b/drivers/scsi/storvsc_drv.c > @@ -1023,6 +1023,13 @@ static void storvsc_handle_error(struct vmscsi_request *vm_srb, > case ATA_12: > set_host_byte(scmnd, DID_PASSTHROUGH); > break; > + /* > + * On Some Windows hosts TEST_UNIT_READY command can return > + * SRB_STATUS_ERROR, let the upper level code deal with it > + * based on the sense information. > + */ > + case TEST_UNIT_READY: > + break; Don't we need to set an error in the command for the error handler to take action? Or is this propagated elsewhere? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/