Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754498AbaGIKop (ORCPT ); Wed, 9 Jul 2014 06:44:45 -0400 Received: from mail-ob0-f180.google.com ([209.85.214.180]:51119 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753465AbaGIKoo (ORCPT ); Wed, 9 Jul 2014 06:44:44 -0400 MIME-Version: 1.0 In-Reply-To: <53BD1A56.7000902@arm.com> References: <53BD1A56.7000902@arm.com> Date: Wed, 9 Jul 2014 16:14:43 +0530 Message-ID: Subject: Re: [RFC 7/7] net: don't check for active hrtimer after adding it From: Viresh Kumar To: Chris Redpath Cc: "tglx@linutronix.de" , "linaro-kernel@lists.linaro.org" , "fweisbec@gmail.com" , "linux-kernel@vger.kernel.org" , "preeti@linux.vnet.ibm.com" , "netdev@vger.kernel.org" , Arvind Chauhan , "David S. Miller" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chris, On 9 July 2014 16:02, Chris Redpath wrote: >> diff --git a/net/core/pktgen.c b/net/core/pktgen.c >> index fc17a9d..f911acd 100644 >> --- a/net/core/pktgen.c >> +++ b/net/core/pktgen.c >> @@ -2186,8 +2186,6 @@ static void spin(struct pktgen_dev *pkt_dev, ktime_t >> spin_until) >> do { >> set_current_state(TASK_INTERRUPTIBLE); >> hrtimer_start_expires(&t.timer, HRTIMER_MODE_ABS); >> - if (!hrtimer_active(&t.timer)) >> - t.task = NULL; >> >> if (likely(t.task)) >> schedule(); > > > I think this if condition can also be removed. hrtimer_init_sleeper copies > the supplied task_struct * to the timer, which in this case is 'current'. > The check is likely to be there in case of !active case you removed. Yeah, it looks like we can get rid of this. Also, } while (t.task && pkt_dev->running && !signal_pending(current)); is present in the closing "}" of do-while loop and probably we don't need to check t.task here as well. And this review comment applies to patch 2/7 as well: hrtimer: don't check for active hrtimer after adding it I would still wait for somebody to prove us wrong :), and will resend it next week only. Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/