Date: Wed, 9 Jul 2014 10:13:54 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: David Vrabel <david.vrabel@citrix.com>, konrad@kernel.org,
        boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org,
        xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] [PATCH v3 1/7] xen-pciback: Document the various
 parameters and attributes in SysFS
Message-ID: <20140709141354.GG21837@laptop.dumpdata.com>
References: <1404845909-13563-1-git-send-email-konrad@kernel.org>
 <1404845909-13563-2-git-send-email-konrad@kernel.org>
 <53BD32C2.6000306@citrix.com>
 <20140709135922.GD21837@laptop.dumpdata.com>
 <53BD4C44.30805@citrix.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <53BD4C44.30805@citrix.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org

On Wed, Jul 09, 2014 at 03:05:56PM +0100, Andrew Cooper wrote:
> On 09/07/14 14:59, Konrad Rzeszutek Wilk wrote:
> >
> >>> +What:           /sys/bus/pci/drivers/pciback/irq_handler_state
> >>> +Date:           Oct 2011
> >>> +KernelVersion:  3.1
> >>> +Contact:        xen-devel@lists.xenproject.org
> >>> +Description:
> >>> +                An option to toggle Xen PCI back to acknowledge (or stop)
> >>> +                interrupts for the specific device regardless of whether the
> >>> +                device is shared, enabled, or on a level interrupt line.
> >>> +                Writing a string of DDDD:BB:DD.F will toggle the state.
> >>> +                This is Domain:Bus:Device.Function where domain is optional.
> >> I do not understand under what circumstances this should be used in.
> > So that dom0 does not disable the IRQ line as it would be getting the IRQs
> > for the guest as well (because the IRQ line is level and another guest
> > uses an PCI device that is using the same line).
> 
> Why is this relevant?  Xen (and Xen alone) actually controls this aspect
> of interrupts.  Xen manages passing line level interrupts to any domain
> which might have a device hanging off a particular line, and has to wait
> until all domains have EOI'd the line until it can clear the interrupt
> at the IO-APIC.

Because Linux will think there is an IRQ storm as the event->IRQ points
to the default one. And then it will mask the event, which means dom0
will mask the PIRQ, and Xen will then also mask the IRQ.
> 
> ~Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/