Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756023AbaGIQq4 (ORCPT ); Wed, 9 Jul 2014 12:46:56 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:41129 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751778AbaGIQqz (ORCPT ); Wed, 9 Jul 2014 12:46:55 -0400 Date: Wed, 9 Jul 2014 09:46:47 -0700 From: Dmitry Torokhov To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Henrik Rydberg , linux-input@vger.kernel.org Subject: Re: [PATCH 1/1] drivers/input/touchscreen/edt-ft5x06.c: remove unnecessary null test before debugfs_remove_recursive Message-ID: <20140709164647.GA10364@core.coreip.homeip.net> References: <1403901512-9710-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1403901512-9710-1-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 27, 2014 at 10:38:32PM +0200, Fabian Frederick wrote: > Fix checkpatch warning: > "WARNING: debugfs_remove_recursive(NULL) is safe this check is probably not required" > > Cc: Dmitry Torokhov > Cc: Henrik Rydberg > Cc: linux-input@vger.kernel.org > Signed-off-by: Fabian Frederick Applied, thank you. > --- > drivers/input/touchscreen/edt-ft5x06.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c > index d4f3399..5a6d50c 100644 > --- a/drivers/input/touchscreen/edt-ft5x06.c > +++ b/drivers/input/touchscreen/edt-ft5x06.c > @@ -733,8 +733,7 @@ edt_ft5x06_ts_prepare_debugfs(struct edt_ft5x06_ts_data *tsdata, > static void > edt_ft5x06_ts_teardown_debugfs(struct edt_ft5x06_ts_data *tsdata) > { > - if (tsdata->debug_dir) > - debugfs_remove_recursive(tsdata->debug_dir); > + debugfs_remove_recursive(tsdata->debug_dir); > kfree(tsdata->raw_buffer); > } > > -- > 1.8.4.5 > -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/