Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932313AbaGIRKj (ORCPT ); Wed, 9 Jul 2014 13:10:39 -0400 Received: from mail-pd0-f170.google.com ([209.85.192.170]:35245 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756668AbaGIRKf (ORCPT ); Wed, 9 Jul 2014 13:10:35 -0400 Date: Wed, 9 Jul 2014 10:10:31 -0700 From: Guenter Roeck To: Kamil Debski Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org, sguinot@lacie.com, t.figa@samsung.com, m.szyprowski@samsung.com Subject: Re: [lm-sensors] [PATCH] hwmon: gpio-fan: Change name passed to hwmon_device_register_with_groups Message-ID: <20140709171031.GA25748@roeck-us.net> References: <1404917613-4467-1-git-send-email-k.debski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404917613-4467-1-git-send-email-k.debski@samsung.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 09, 2014 at 04:53:32PM +0200, Kamil Debski wrote: > Commit 648cd48c9e566f53c5df30d79857e0937ae13b09 (hwmon: Do not accept > invalid name attributes) added check for "-" in the name of hwmon device. > This patch changes the name supplied by gpio-fan so that it is accepted > by hwmon. > > Signed-off-by: Kamil Debski > --- > drivers/hwmon/gpio-fan.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwmon/gpio-fan.c b/drivers/hwmon/gpio-fan.c > index ba35e4d..5acd555 100644 > --- a/drivers/hwmon/gpio-fan.c > +++ b/drivers/hwmon/gpio-fan.c > @@ -538,7 +538,7 @@ static int gpio_fan_probe(struct platform_device *pdev) > > /* Make this driver part of hwmon class. */ > fan_data->hwmon_dev = hwmon_device_register_with_groups(&pdev->dev, > - "gpio-fan", fan_data, > + "gpiofan", fan_data, This has already been changed to "gpio_fan" in the latest kernel. See commit d26e0da78 (hwmon: (gpio-fan) Change name used in hwmon_device_register_with_groups). Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/