Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756044AbaGISCH (ORCPT ); Wed, 9 Jul 2014 14:02:07 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:47817 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752746AbaGISCD (ORCPT ); Wed, 9 Jul 2014 14:02:03 -0400 Message-ID: <53BD8398.6020507@codeaurora.org> Date: Wed, 09 Jul 2014 11:02:00 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Rickard Strandqvist CC: David Brown , Daniel Walker , Bryan Huntsman , Greg Kroah-Hartman , Jiri Slaby , Grant Likely , Rob Herring , linux-arm-msm@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v2] tty: serial: msm_serial.c: Cleaning up uninitialized variables References: <1404665232-14311-1-git-send-email-rickard_strandqvist@spectrumdigital.se> In-Reply-To: <1404665232-14311-1-git-send-email-rickard_strandqvist@spectrumdigital.se> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/14 09:47, Rickard Strandqvist wrote: > Set reasonable initial value of some variables, in case > they do not get set to something otherwise. > And I've also added a plausibility control of the values. > > Signed-off-by: Rickard Strandqvist > --- This patch doesn't look right... > @@ -930,17 +930,21 @@ static int __init msm_console_setup(struct console *co, char *options) > > msm_init_clock(port); > > - if (options) > + if (options) { > uart_parse_options(options, &baud, &parity, &bits, &flow); > + if (baud < 300 || baud > 115200) > + baud = 115200; > + if (NULL == strchr("noeNOE", parity)) > + parity = 'n'; > + if (bits != 7) > + bits = 8; > + if (flow != 'r') > + flow = 'n'; > + } > > - bits = 8; > - parity = 'n'; > - flow = 'n'; > msm_write(port, UART_MR2_BITS_PER_CHAR_8 | UART_MR2_STOP_BIT_LEN_ONE, > UART_MR2); /* 8N1 */ > because this code is overriding whatever is parsed from uart_parse_options() on purpose. The hardware is configured for 8 bits, no parity, no flow control with this msm_write() statement. Maybe we should extend the code to configure the parity and flow control bits instead. > - if (baud < 300 || baud > 115200) > - baud = 115200; > msm_set_baud_rate(port, baud); > > msm_reset(port); -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/