Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756729AbaGITM3 (ORCPT ); Wed, 9 Jul 2014 15:12:29 -0400 Received: from mail.kernel.org ([198.145.19.201]:36093 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755856AbaGITM1 (ORCPT ); Wed, 9 Jul 2014 15:12:27 -0400 Date: Wed, 9 Jul 2014 16:12:23 -0300 From: Arnaldo Carvalho de Melo To: Joseph Schuchart Cc: Jiri Olsa , Namhyung Kim , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Thomas Ilsche , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] perf script: Add callchain to generic and tracepoint events Message-ID: <20140709191223.GE5721@kernel.org> References: <533D2283.3090703@tu-dresden.de> <87wqd5f7j5.fsf@sejong.aot.lge.com> <538F0BF2.1010806@tu-dresden.de> <20140707171706.GA20752@krava.redhat.com> <53BCF1F2.70100@tu-dresden.de> <20140709112721.GC1814@krava.redhat.com> <53BD2AD6.6020309@tu-dresden.de> <20140709114903.GA5767@krava.redhat.com> <53BD4EC1.1060907@tu-dresden.de> <20140709190921.GD5721@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140709190921.GD5721@kernel.org> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Wed, Jul 09, 2014 at 04:09:21PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Jul 09, 2014 at 04:16:33PM +0200, Joseph Schuchart escreveu: > > > > perf script: Add callchain to generic and tracepoint events. Since > > this alters the interface for the python scripts, also adjust the script > > generation and the provided scripts. > > > > Signed-off-by: Joseph Schuchart > > Acked-by: Thomas Ilsche > > This one is not applying, I'm checking the reason for its malformation > as stated in: > > > [acme@ssdandy linux]$ patch -p1 < /wb/1.patch > patching file tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Core.py > Hunk #1 FAILED at 107. > 1 out of 1 hunk FAILED -- saving rejects to file tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Core.py.rej > patching file tools/perf/scripts/python/check-perf-trace.py > Hunk #1 succeeded at 27 with fuzz 1. > Hunk #2 succeeded at 37 with fuzz 2 (offset -1 lines). > patching file tools/perf/scripts/python/failed-syscalls-by-pid.py > Hunk #1 FAILED at 39. > 1 out of 1 hunk FAILED -- saving rejects to file tools/perf/scripts/python/failed-syscalls-by-pid.py.rej > patching file tools/perf/scripts/python/futex-contention.py > patch: **** malformed patch at line 154: ain, It is full of: self.cpu =3D common_cpu self.secs =3D common_secs self.nsecs =3D common_nsecs self.pid =3D common_pid self.comm =3D common_comm + self.callchain =3D common_callchain =20 def ts(self): See those =20, =3D? Some encoding problem... So you used: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 Please read the Thunderbird specific part of this page: https://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html - Arnaldo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/