From: "Luck, Tony" <tony.luck@intel.com>
To: Havard Skinnemoen <hskinnemoen@google.com>, Borislav Petkov <bp@alien8.de>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Ewout van Bekkum" <ewout@google.com>
Subject: RE: [PATCH 2/6] x86-mce: Modify CMCI storm exit to reenable instead
 of rediscover banks.
Thread-Topic: [PATCH 2/6] x86-mce: Modify CMCI storm exit to reenable
 instead of rediscover banks.
Thread-Index: AQHPm5j+9/jcYklCLkGqPwCvlFaVaJuYLliA
Date: Wed, 9 Jul 2014 20:20:41 +0000
Message-ID: <3908561D78D1C84285E8C5FCA982C28F328573E4@ORSMSX114.amr.corp.intel.com>
References: <1404925766-32253-1-git-send-email-hskinnemoen@google.com>
 <1404925766-32253-3-git-send-email-hskinnemoen@google.com>
In-Reply-To: <1404925766-32253-3-git-send-email-hskinnemoen@google.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org

> The CMCI storm handler previously called cmci_reenable() when exiting a
> CMCI storm. However, when entering a CMCI storm the bank ownership was
> not relinquished by the affected CPUs. The CMCIs were only disabled via
> cmci_storm_disable_banks(). The handler was updated to instead call a
> new function, cmci_storm_enable_banks(), to reenable CMCI on the already
> owned banks instead of rediscovering CMCI banks (which were still owned
> but disabled).

Won't this cause problems if we online a cpu during the storm. We will
re-run the discovery algorithm and some other cpu that shares the bank
will see MCi_CTL2{30} is zero and claim ownership.

-Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/