Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752056AbaGIUky (ORCPT ); Wed, 9 Jul 2014 16:40:54 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:54807 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbaGIUkw (ORCPT ); Wed, 9 Jul 2014 16:40:52 -0400 MIME-Version: 1.0 In-Reply-To: <1404930382.932.143.camel@joe-AO725> References: <1404919470-26668-1-git-send-email-andriy.shevchenko@linux.intel.com> <1404919470-26668-5-git-send-email-andriy.shevchenko@linux.intel.com> <1404930382.932.143.camel@joe-AO725> Date: Wed, 9 Jul 2014 23:40:51 +0300 Message-ID: Subject: Re: [PATCH v1 4/5] parisc: use seq_hex_dump() to dump buffers From: Andy Shevchenko To: Joe Perches Cc: Andy Shevchenko , Tadeusz Struk , Herbert Xu , Mauro Carvalho Chehab , Helge Deller , Ingo Tuchscherer , linux390@de.ibm.com, Alexander Viro , qat-linux@intel.com, linux-crypto@vger.kernel.org, linux-media@vger.kernel.org, linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org In one case indeed it does, in another - no, though it seems it prints same data (by meaning) in both cases. I would like driver maintainer to say a word what they think about it. On Wed, Jul 9, 2014 at 9:26 PM, Joe Perches wrote: > On Wed, 2014-07-09 at 18:24 +0300, Andy Shevchenko wrote: >> Instead of custom approach let's use recently introduced seq_hex_dump() helper. > > Doesn't this also change the output from > 1111111122222222333333334444444455555555666666667777777788888888 > to > 11111111 22222222 33333333 44444444 55555555 66666666 77777777 88888888 > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/