Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756119AbaGIWfX (ORCPT ); Wed, 9 Jul 2014 18:35:23 -0400 Received: from mail-vc0-f176.google.com ([209.85.220.176]:48649 "EHLO mail-vc0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751753AbaGIWfW (ORCPT ); Wed, 9 Jul 2014 18:35:22 -0400 MIME-Version: 1.0 X-Originating-IP: [2620:0:1000:157d:8cce:4220:32bc:b297] In-Reply-To: <20140703181059.GJ17372@arm.com> References: <1404324218-4743-1-git-send-email-lauraa@codeaurora.org> <1404324218-4743-2-git-send-email-lauraa@codeaurora.org> <20140703181059.GJ17372@arm.com> Date: Wed, 9 Jul 2014 15:35:21 -0700 Message-ID: Subject: Re: [PATCHv4 1/5] lib/genalloc.c: Add power aligned algorithm From: Olof Johansson To: Will Deacon Cc: Laura Abbott , Catalin Marinas , David Riley , "linux-arm-kernel@lists.infradead.org" , Ritesh Harjain , "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 3, 2014 at 11:10 AM, Will Deacon wrote: > On Wed, Jul 02, 2014 at 07:03:34PM +0100, Laura Abbott wrote: >> >> One of the more common algorithms used for allocation >> is to align the start address of the allocation to >> the order of size requested. Add this as an algorithm >> option for genalloc. >> >> Signed-off-by: Laura Abbott >> --- >> include/linux/genalloc.h | 4 ++++ >> lib/genalloc.c | 20 ++++++++++++++++++++ >> 2 files changed, 24 insertions(+) >> >> diff --git a/include/linux/genalloc.h b/include/linux/genalloc.h >> index 1c2fdaa..3cd0934 100644 >> --- a/include/linux/genalloc.h >> +++ b/include/linux/genalloc.h >> @@ -110,6 +110,10 @@ extern void gen_pool_set_algo(struct gen_pool *pool, genpool_algo_t algo, >> extern unsigned long gen_pool_first_fit(unsigned long *map, unsigned long size, >> unsigned long start, unsigned int nr, void *data); >> >> +extern unsigned long gen_pool_first_fit_order_align(unsigned long *map, >> + unsigned long size, unsigned long start, unsigned int nr, >> + void *data); >> + > > You could also update gen_pool_first_fit to call this new function instead. +1, that'd be slightly nicer and remove one exported symbol. But, as Will says, up to you. Either option: Acked-by: Olof Johansson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/