Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751173AbaGJEh6 (ORCPT ); Thu, 10 Jul 2014 00:37:58 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:50982 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750702AbaGJEh5 (ORCPT ); Thu, 10 Jul 2014 00:37:57 -0400 Date: Wed, 9 Jul 2014 21:37:38 -0700 From: Greg Kroah-Hartman To: WANG Chao Cc: Andrew Morton , Zhang Yanfei , Minchan Kim , Nitin Gupta , Rusty Russell , Chris Metcalf , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2] mm/vmalloc.c: clean up map_vm_area third argument Message-ID: <20140710043738.GA13532@kroah.com> References: <1404721943-6506-1-git-send-email-chaowang@redhat.com> <1404966367-7599-1-git-send-email-chaowang@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404966367-7599-1-git-send-email-chaowang@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 10, 2014 at 12:26:07PM +0800, WANG Chao wrote: > Currently map_vm_area() takes (struct page *** pages) as third argument, > and after mapping, it moves (*pages) to point to (*pages + nr_mappped_pages). > > It looks like this kind of increment is useless to its caller these > days. The callers don't care about the increments and actually they're > trying to avoid this by passing another copy to map_vm_area(). > > The caller can always guarantee all the pages can be mapped into > vm_area as specified in first argument and the caller only cares about > whether map_vm_area() fails or not. > > This patch cleans up the pointer movement in map_vm_area() and updates > its callers accordingly. > > v2: Fix arch/tile/kernel/module.c::module_alloc(). > > Signed-off-by: WANG Chao > --- > arch/tile/kernel/module.c | 2 +- > drivers/lguest/core.c | 7 ++----- > drivers/staging/android/binder.c | 4 +--- > include/linux/vmalloc.h | 2 +- > mm/vmalloc.c | 14 +++++--------- > mm/zsmalloc.c | 2 +- > 6 files changed, 11 insertions(+), 20 deletions(-) Staging code: Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/