Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861AbaGJJl2 (ORCPT ); Thu, 10 Jul 2014 05:41:28 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:41097 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751420AbaGJJl0 (ORCPT ); Thu, 10 Jul 2014 05:41:26 -0400 X-Auth-Info: oFQ/DsYM3bynkHSm+YmfjWwsEoq7pdh2ySYPjslPR+E= From: Marek Vasut To: Dmitry Kasatkin Subject: Re: [PATCH v3 1/3] ima: use ahash API for file hash calculation Date: Thu, 10 Jul 2014 10:02:07 +0200 User-Agent: KMail/1.13.7 (Linux/3.13-trunk-amd64; KDE/4.13.1; x86_64; ; ) Cc: Dmitry Kasatkin , Mimi Zohar , linux-ima-devel@lists.sourceforge.net, "linux-security-module" , "linux-kernel@vger.kernel.org" , "linux-crypto" References: <201407092300.25224.marex@denx.de> In-Reply-To: MIME-Version: 1.0 Content-Type: Text/Plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <201407101002.07535.marex@denx.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, July 10, 2014 at 01:05:39 AM, Dmitry Kasatkin wrote: > On 10 July 2014 00:00, Marek Vasut wrote: > > On Tuesday, July 08, 2014 at 10:07:16 AM, Dmitry Kasatkin wrote: > > [...] > > > >> > Right, but my concern is not about unloading the kernel module, but > >> > about the IMA module parameters left initialized. The existing code > >> > will continue using ahash (software version), even though the kernel > >> > module was unloaded, not shash. My question is about the software > >> > implementations of ahash vs. shash performance. > >> > > >> > Mimi > >> > >> If HW driver will not be available, ahash loads generic driver which is > >> using shash. > >> Performance of that will be the same as for using shash directly. > > > > Hi Dmitry, I think Mimi is concerned about the crypto accelerator dying > > mid- flight. > > > > Imagine a situation where you have a hardware crypto accelerator > > connected via USB. You happily use IMA with this setup for days and then > > someone comes around and pulls the USB cable out. Will this be able to > > cope with such situation, for example by switching to software > > operations or such in some sane way ? > > > > I presume that's the concern here. > > > > Best regards, > > Marek Vasut > > Hi Marek, Hi! > Nice to here from you. How was your rest stay at Japan? Thanks for asking, not sure there is a super-positive ultra-awesome word to express that, so in short, I had the time of my life. Love that country ;-) > I have not seen any expression of such concern. All right, that was my understanding of the entire discussion -- an accelerator dying mid-way and what will IMA do about that. > But as we fallback to early allocated shash, which is not USB yet, > then there is no problem. > ahash itself does not bring any other additional problem than shash itself. > They are compiled builtin together. Sure, I understood that. But what will happen if the ahash accelerator stops working mid-flight, will IMA also go bonkers or is there some graceful stop? Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/