Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751818AbaGJKWH (ORCPT ); Thu, 10 Jul 2014 06:22:07 -0400 Received: from mail-qg0-f44.google.com ([209.85.192.44]:33167 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750958AbaGJKWF convert rfc822-to-8bit (ORCPT ); Thu, 10 Jul 2014 06:22:05 -0400 MIME-Version: 1.0 X-Originating-IP: [84.208.72.173] In-Reply-To: <87tx6ph8u5.fsf@nemi.mork.no> References: <1404980258-30853-1-git-send-email-teg@jklm.no> <1404980258-30853-4-git-send-email-teg@jklm.no> <87tx6ph8u5.fsf@nemi.mork.no> From: Tom Gundersen Date: Thu, 10 Jul 2014 12:21:44 +0200 Message-ID: Subject: Re: [PATCH v7 03/33] net: set name_assign_type in alloc_netdev() To: =?UTF-8?Q?Bj=C3=B8rn_Mork?= Cc: netdev , LKML , David Miller , David Herrmann , Kay Sievers Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 10, 2014 at 11:16 AM, Bjørn Mork wrote: > Tom Gundersen writes: > >> diff --git a/net/ethernet/eth.c b/net/ethernet/eth.c >> index 5dc638c..f405e05 100644 >> --- a/net/ethernet/eth.c >> +++ b/net/ethernet/eth.c >> @@ -390,7 +390,8 @@ EXPORT_SYMBOL(ether_setup); >> struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs, >> unsigned int rxqs) >> { >> - return alloc_netdev_mqs(sizeof_priv, "eth%d", ether_setup, txqs, rxqs); >> + return alloc_netdev_mqs(sizeof_priv, "eth%d", NET_NAME_UNKNOWN, >> + ether_setup, txqs, rxqs); >> } >> EXPORT_SYMBOL(alloc_etherdev_mqs); > > I believe this chunk makes the rest of this exercise pretty pointless. > > bjorn@nemi:/usr/local/src/git/linux$ git grep alloc_etherdev drivers/net/|wc -l > 283 > > I don't care enough to go look, but I'd be surprised if none of those > drivers rename the device before registering it. I did look for that, and I only found devices being renamed to the same name assign type as eth%d (wlan%d, etc). Cheers, Tom -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/