Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752003AbaGJK02 (ORCPT ); Thu, 10 Jul 2014 06:26:28 -0400 Received: from mail-ie0-f181.google.com ([209.85.223.181]:41445 "EHLO mail-ie0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751008AbaGJK00 (ORCPT ); Thu, 10 Jul 2014 06:26:26 -0400 MIME-Version: 1.0 In-Reply-To: References: <1404980258-30853-1-git-send-email-teg@jklm.no> <1404980258-30853-11-git-send-email-teg@jklm.no> <87pphdh85q.fsf@nemi.mork.no> Date: Thu, 10 Jul 2014 12:26:25 +0200 Message-ID: Subject: Re: [PATCH v7 10/33] net: dummy - set name assign type From: David Herrmann To: Tom Gundersen Cc: =?UTF-8?Q?Bj=C3=B8rn_Mork?= , netdev , LKML , David Miller , Kay Sievers , dingtianhong , Tan Xiaojun , WANG Cong Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi >> The same goes for NET_NAME_USER and NET_NAME_RENAMED. These are the same >> from a kernel point of view. > > You mean to collapse the two, and just label renamed interfaces > NET_NAME_USER instead? I have no real objections to merging NAME_USER and NAME_RENAMED. Both values imply that there is a user-space authority that applied some kind of rules to the naming-scheme. Therefore, anyone reacting to those names should better treat them equally and fix the naming-authority instead of overwriting it. However, at the same time I think there's no real harm in keeping them separate, either. My original thinking was to provide a second layer for anyone overwriting system defaults. For instance, if there's a user-space given name and a system-administrator wants to rename that for administrative purposes, they can safely match on NAME_USER and be sure, it wasn't renamed, yet. If it is set to NAME_RENAMED, though, then the administrator has some kind of safety-net that tells him he already has a rule that renamed the device and he shouldn't add another one (like placing one in initrd and one in the real root). Anyhow, if no-one cares about that, please go ahead and squash both into NET_NAME_USER. Thanks David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/