Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752106AbaGJKeU (ORCPT ); Thu, 10 Jul 2014 06:34:20 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:43041 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbaGJKeS (ORCPT ); Thu, 10 Jul 2014 06:34:18 -0400 MIME-Version: 1.0 X-Originating-IP: [84.208.72.173] In-Reply-To: References: <1404980258-30853-1-git-send-email-teg@jklm.no> <1404980258-30853-11-git-send-email-teg@jklm.no> <87pphdh85q.fsf@nemi.mork.no> From: Tom Gundersen Date: Thu, 10 Jul 2014 12:33:57 +0200 Message-ID: Subject: Re: [PATCH v7 10/33] net: dummy - set name assign type To: David Herrmann Cc: =?UTF-8?Q?Bj=C3=B8rn_Mork?= , netdev , LKML , David Miller , Kay Sievers , dingtianhong , Tan Xiaojun , WANG Cong Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 10, 2014 at 12:26 PM, David Herrmann wrote: > Hi > >>> The same goes for NET_NAME_USER and NET_NAME_RENAMED. These are the same >>> from a kernel point of view. >> >> You mean to collapse the two, and just label renamed interfaces >> NET_NAME_USER instead? > > I have no real objections to merging NAME_USER and NAME_RENAMED. Both > values imply that there is a user-space authority that applied some > kind of rules to the naming-scheme. Therefore, anyone reacting to > those names should better treat them equally and fix the > naming-authority instead of overwriting it. I basically agree. There is no strong reason to keep these separate, so I would not object strongly to merging them. However, I also don't see any harm in keeping the distinction. If userspace wants to treat them the same, it easily can. However, if a usecase appears in the future where the distinction is important, we can no longer split them apart again. For that reason, I'd slightly prefer keeping them separate, unless there is a compelling reason not to... Cheers, Tom -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/