Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752144AbaGJLI5 (ORCPT ); Thu, 10 Jul 2014 07:08:57 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:60724 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751083AbaGJLIz (ORCPT ); Thu, 10 Jul 2014 07:08:55 -0400 From: "Rafael J. Wysocki" To: "Li, Aubrey" Cc: Dmitry Torokhov , "linux-input@vger.kernel.org" , LKML , One Thousand Gnomes , Linux PM list Subject: Re: [PATCH] GPIO button wth wakeup attribute is supposed to wake the system up Date: Thu, 10 Jul 2014 13:27:02 +0200 Message-ID: <1614271.1peg23gJZx@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/3.15.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <53BDFA22.2000409@linux.intel.com> References: <53A2340D.9030503@linux.intel.com> <4301161.i6ArOLmcsg@vostro.rjw.lan> <53BDFA22.2000409@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, July 10, 2014 10:27:46 AM Li, Aubrey wrote: > On 2014/7/9 20:45, Rafael J. Wysocki wrote: > > On Tuesday, July 08, 2014 05:54:35 PM Dmitry Torokhov wrote: > >> On Wed, Jul 09, 2014 at 02:59:33AM +0200, Rafael J. Wysocki wrote: > >>> On Tuesday, July 08, 2014 05:15:06 PM Dmitry Torokhov wrote: > >>>> On Wed, Jul 09, 2014 at 01:06:07AM +0200, Rafael J. Wysocki wrote: > > > > [cut] > > > >>>> > >>>> When device driver marks IRQ as a wakeup source I believe it is prepared > >>>> to handle it (or it would shut it off explicitly). > >>> > >>> I can agree with that. > >>> > >>> Are you suggesting that __disable_irq() should check irq_data for > >>> IRQD_WAKEUP_STATE and skip the IRQ (in the 'suspend' case) if that is set? > >> > >> Yes, something like that. > > > > OK > > Many thanks to you both for the discussion. > > > > Aubrey, can you please check if the appended patch helps on the T100? > > I verified this patch on T100, it works as expected, freeze can be waken > up by reverting my patch and applying this one. Thanks! > Is this a final solution? I hope so. I'll resend it with a proper changelog later today. Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/