Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752953AbaGJMIZ (ORCPT ); Thu, 10 Jul 2014 08:08:25 -0400 Received: from mail-oa0-f50.google.com ([209.85.219.50]:51267 "EHLO mail-oa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbaGJMIX (ORCPT ); Thu, 10 Jul 2014 08:08:23 -0400 MIME-Version: 1.0 In-Reply-To: <20140710115934.GF2970@pd.tnic> References: <9e68cba2bf41923630ea93de7c3d17637f175895.1403772686.git.viresh.kumar@linaro.org> <20140710114828.GA3254@pd.tnic> <20140710115934.GF2970@pd.tnic> Date: Thu, 10 Jul 2014 17:38:23 +0530 Message-ID: Subject: Re: [PATCH] cpufreq: report driver's successful {un}registration From: Viresh Kumar To: Borislav Petkov Cc: "Rafael J. Wysocki" , Lists linaro-kernel , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , Arvind Chauhan Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10 July 2014 17:29, Borislav Petkov wrote: > On Thu, Jul 10, 2014 at 05:21:43PM +0530, Viresh Kumar wrote: >> So that it appears in boot logs and we know cpufreq registered properly. > > So flip that logic: Don't say anything in the success case and issue an > error only when it failed. Like the rest of the code does it. The problem with that is: CPUFreq may not be compiled in at all and we wouldn't know the difference between success and absence. And so tried to add a print, like any other driver would do. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/