Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752757AbaGJTjE (ORCPT ); Thu, 10 Jul 2014 15:39:04 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:42759 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbaGJTjC (ORCPT ); Thu, 10 Jul 2014 15:39:02 -0400 Date: Thu, 10 Jul 2014 12:39:00 -0700 (PDT) Message-Id: <20140710.123900.1696373067218564684.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: f.fainelli@gmail.com, santosh.shilimkar@ti.com, netdev@vger.kernel.org, prabhakar.csengg@gmail.com, nsekhar@ti.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, davinci-linux-open-source@linux.davincidsp.com Subject: Re: [PATCH 1/2] net: davinci_mdio: reuse for keystone2 arch From: David Miller In-Reply-To: <53BE8DF7.9090303@ti.com> References: <1404911451-9921-2-git-send-email-grygorii.strashko@ti.com> <20140709.165232.539576872991411664.davem@davemloft.net> <53BE8DF7.9090303@ti.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.7 (shards.monkeyblade.net [149.20.54.216]); Thu, 10 Jul 2014 12:39:01 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Thu, 10 Jul 2014 15:58:31 +0300 > Hi David, > > On 07/10/2014 02:52 AM, David Miller wrote: >> From: Grygorii Strashko >> Date: Wed, 9 Jul 2014 16:10:50 +0300 >> >>> Required properties: >>> -- compatible : Should be "ti,davinci_mdio" >>> +- compatible : Should be "ti,davinci_mdio" or "ti,keystone-mdio" >> >> Why the inconsistency in naming schemes? I don't see any reason >> to be different wrt. "_" vs. "-" in the name string. >> > > Hm. Looks like the common way is to use "-", but I can rename it if you insist. I'm just saying, is there a strong reason to be inconsistent? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/