Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751169AbaGKFj1 (ORCPT ); Fri, 11 Jul 2014 01:39:27 -0400 Received: from mga14.intel.com ([192.55.52.115]:50349 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750975AbaGKFj0 (ORCPT ); Fri, 11 Jul 2014 01:39:26 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.01,642,1400050800"; d="scan'208";a="560318622" Message-ID: <53BF7818.8070506@intel.com> Date: Fri, 11 Jul 2014 13:37:28 +0800 From: "Yan, Zheng" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Stephane Eranian , LKML CC: Peter Zijlstra , "mingo@elte.hu" , "ak@linux.intel.com" Subject: Re: [PATCH] perf/x86/uncore: fix SNB-EP/IVT Cbox filter mappings References: <20140630144624.GA2604@quad> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/11/2014 03:16 AM, Stephane Eranian wrote: > On Mon, Jun 30, 2014 at 4:46 PM, Stephane Eranian wrote: >> >> This patch fixes the SNB-EP and IVT Cbox filter mapping >> table. The table controls which filters are supported by >> which events. There were several mistakes in those tables >> causing some filters to be ignored, such as NID on >> TOR_INSERTS. >> >> Signed-off-by: Stephane Eranian > > Any comment on this patch? sorry for the delay Reviewed-by: Yan, Zheng > >> --- >> arch/x86/kernel/cpu/perf_event_intel_uncore.c | 11 ++++++----- >> 1 file changed, 6 insertions(+), 5 deletions(-) >> >> diff --git a/arch/x86/kernel/cpu/perf_event_intel_uncore.c b/arch/x86/kernel/cpu/perf_event_intel_uncore.c >> index 65bbbea..ae6552a 100644 >> --- a/arch/x86/kernel/cpu/perf_event_intel_uncore.c >> +++ b/arch/x86/kernel/cpu/perf_event_intel_uncore.c >> @@ -550,16 +550,16 @@ static struct extra_reg snbep_uncore_cbox_extra_regs[] = { >> SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0x6), >> SNBEP_CBO_EVENT_EXTRA_REG(0x0135, 0xffff, 0x8), >> SNBEP_CBO_EVENT_EXTRA_REG(0x0335, 0xffff, 0x8), >> - SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xc), >> - SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xc), >> + SNBEP_CBO_EVENT_EXTRA_REG(0x4135, 0xffff, 0xa), >> + SNBEP_CBO_EVENT_EXTRA_REG(0x4335, 0xffff, 0xa), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4435, 0xffff, 0x2), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4835, 0xffff, 0x2), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4a35, 0xffff, 0x2), >> SNBEP_CBO_EVENT_EXTRA_REG(0x5035, 0xffff, 0x2), >> SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x8), >> SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x8), >> - SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xc), >> - SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xc), >> + SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0xa), >> + SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0xa), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4436, 0xffff, 0x2), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4836, 0xffff, 0x2), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4a36, 0xffff, 0x2), >> @@ -1222,6 +1222,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = { >> SNBEP_CBO_EVENT_EXTRA_REG(SNBEP_CBO_PMON_CTL_TID_EN, >> SNBEP_CBO_PMON_CTL_TID_EN, 0x1), >> SNBEP_CBO_EVENT_EXTRA_REG(0x1031, 0x10ff, 0x2), >> + >> SNBEP_CBO_EVENT_EXTRA_REG(0x1134, 0xffff, 0x4), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4134, 0xffff, 0xc), >> SNBEP_CBO_EVENT_EXTRA_REG(0x5134, 0xffff, 0xc), >> @@ -1245,7 +1246,7 @@ static struct extra_reg ivt_uncore_cbox_extra_regs[] = { >> SNBEP_CBO_EVENT_EXTRA_REG(0x8335, 0xffff, 0x10), >> SNBEP_CBO_EVENT_EXTRA_REG(0x0136, 0xffff, 0x10), >> SNBEP_CBO_EVENT_EXTRA_REG(0x0336, 0xffff, 0x10), >> - SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10), >> + SNBEP_CBO_EVENT_EXTRA_REG(0x2136, 0xffff, 0x10), >> SNBEP_CBO_EVENT_EXTRA_REG(0x2336, 0xffff, 0x10), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4136, 0xffff, 0x18), >> SNBEP_CBO_EVENT_EXTRA_REG(0x4336, 0xffff, 0x18), >> -- >> 1.8.3.2 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/