Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751776AbaGKF7w (ORCPT ); Fri, 11 Jul 2014 01:59:52 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:58184 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbaGKF7u (ORCPT ); Fri, 11 Jul 2014 01:59:50 -0400 MIME-Version: 1.0 In-Reply-To: <1404992799-3705-13-git-send-email-wsa@the-dreams.de> References: <1404992799-3705-1-git-send-email-wsa@the-dreams.de> <1404992799-3705-13-git-send-email-wsa@the-dreams.de> Date: Fri, 11 Jul 2014 11:29:46 +0530 Message-ID: Subject: Re: [PATCH 12/16] i2c: i2c-s3c2410: Drop class based scanning to improve bootup time From: Sachin Kamat To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , Ben Dooks , Kukjin Kim , linux-samsung-soc , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wolfram, On Thu, Jul 10, 2014 at 5:16 PM, Wolfram Sang wrote: > This driver has been flagged to drop class based instantiation. The removal > improves boot-up time and is unneeded for embedded controllers. Users have been > warned to switch for some time now, so we can actually do the removal. Keep the > DEPRECATED flag, so the core can inform users that the behaviour finally > changed now. After another transition period, this flag can go, too. > While we are here, remove the indentation for the array setup because > such things always break after some time. > > Signed-off-by: Wolfram Sang > --- > drivers/i2c/busses/i2c-s3c2410.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-s3c2410.c b/drivers/i2c/busses/i2c-s3c2410.c > index e828a1dba0e5..6252c051525a 100644 > --- a/drivers/i2c/busses/i2c-s3c2410.c > +++ b/drivers/i2c/busses/i2c-s3c2410.c > @@ -1128,11 +1128,11 @@ static int s3c24xx_i2c_probe(struct platform_device *pdev) > s3c24xx_i2c_parse_dt(pdev->dev.of_node, i2c); > > strlcpy(i2c->adap.name, "s3c2410-i2c", sizeof(i2c->adap.name)); > - i2c->adap.owner = THIS_MODULE; > - i2c->adap.algo = &s3c24xx_i2c_algorithm; > + i2c->adap.owner = THIS_MODULE; > + i2c->adap.algo = &s3c24xx_i2c_algorithm; > i2c->adap.retries = 2; > - i2c->adap.class = I2C_CLASS_HWMON | I2C_CLASS_SPD | I2C_CLASS_DEPRECATED; > - i2c->tx_setup = 50; > + i2c->adap.class = I2C_CLASS_DEPRECATED; > + i2c->tx_setup = 50; > > init_waitqueue_head(&i2c->wait); > > -- Tested on Exynos 5250 boards. Tested-by: Sachin Kamat -- Regards, Sachin. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/