Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754692AbaGKOCc (ORCPT ); Fri, 11 Jul 2014 10:02:32 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:53178 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750941AbaGKOCb (ORCPT ); Fri, 11 Jul 2014 10:02:31 -0400 Message-ID: <1405087244.4630.15.camel@weser.hi.pengutronix.de> Subject: Re: [PATCH] can: flexcan: add vf61x support for flexcan From: Lucas Stach To: Stefan Agner Cc: Marc Kleine-Budde , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org, wg@grandegger.com, kernel@pengutronix.de, shawn.guo@freescale.com Date: Fri, 11 Jul 2014 16:00:44 +0200 In-Reply-To: References: <1405075933-22317-1-git-send-email-stefan@agner.ch> <53BFD401.8030101@pengutronix.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.8.5-2+b1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:6f8:1178:2:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Freitag, den 11.07.2014, 15:58 +0200 schrieb Stefan Agner: > Hi Marc, > > Am 2014-07-11 14:09, schrieb Marc Kleine-Budde: > > IMHO it should be 4 seperate patches: > > - dt > > - clocks > > - flexcan_get_berr_counter fixes > > - your flexcan enhancements > > Ok, will split. > > >> @@ -362,7 +374,7 @@ > >> > >> esdhc1: esdhc@400b2000 { > >> compatible = "fsl,imx53-esdhc"; > >> - reg = <0x400b2000 0x4000>; > >> + reg = <0x400b2000 0x1000>; > > > > What's that doing here? :) > > That's an error I just stumbled upon. I know it's not related but it's > such a small change... Do I need to make a separate patch for that or > can I include it in the FlexCAN dt commit? > Upstream changes are meant to be traceable by reading the git log. Thus no drive-by changes are allowed in unrelated commits. This absolutely needs to be a separate patch. Regards, Lucas -- Pengutronix e.K. | Lucas Stach | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/