Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754111AbaGKP4R (ORCPT ); Fri, 11 Jul 2014 11:56:17 -0400 Received: from qmta02.emeryville.ca.mail.comcast.net ([76.96.30.24]:48416 "EHLO qmta02.emeryville.ca.mail.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753503AbaGKP4N (ORCPT ); Fri, 11 Jul 2014 11:56:13 -0400 Date: Fri, 11 Jul 2014 10:55:59 -0500 (CDT) From: Christoph Lameter To: Tejun Heo cc: Jiang Liu , Andrew Morton , Mel Gorman , David Rientjes , Mike Galbraith , Peter Zijlstra , "Rafael J . Wysocki" , Vladimir Davydov , Johannes Weiner , "Kirill A. Shutemov" , Rik van Riel , Wanpeng Li , Zhang Yanfei , Catalin Marinas , Jianyu Zhan , malc , Joonsoo Kim , Fabian Frederick , Tony Luck , linux-mm@kvack.org, linux-hotplug@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC Patch V1 07/30] mm: Use cpu_to_mem()/numa_mem_id() to support memoryless node In-Reply-To: <20140711153302.GA30865@htj.dyndns.org> Message-ID: References: <1405064267-11678-1-git-send-email-jiang.liu@linux.intel.com> <1405064267-11678-8-git-send-email-jiang.liu@linux.intel.com> <20140711144205.GA27706@htj.dyndns.org> <20140711152156.GB29137@htj.dyndns.org> <20140711153302.GA30865@htj.dyndns.org> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 11 Jul 2014, Tejun Heo wrote: > On Fri, Jul 11, 2014 at 11:21:56AM -0400, Tejun Heo wrote: > > Even if that's the case, there's no reason to burden everyone with > > this distinction. Most users just wanna say "I'm on this node. > > Please allocate considering that". There's nothing wrong with using > > numa_node_id() for that. > > Also, this is minor but don't we also lose fallback information by > doing this from the caller? Please consider the following topology > where each hop is the same distance. > > A - B - X - C - D > > Where X is the memless node. num_mem_id() on X would return either B > or C, right? If B or C can't satisfy the allocation, the allocator > would fallback to A from B and D for C, both of which aren't optimal. > It should first fall back to C or B respectively, which the allocator > can't do anymoe because the information is lost when the caller side > performs numa_mem_id(). True but the advantage is that the numa_mem_id() allows the use of a consitent sort of "local" node which increases allocator performance due to the abillity to cache objects from that node. > Seems pretty misguided to me. IMHO the whole concept of a memoryless node looks pretty misguided to me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/