Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755340AbaGKWJI (ORCPT ); Fri, 11 Jul 2014 18:09:08 -0400 Received: from mail-we0-f172.google.com ([74.125.82.172]:45517 "EHLO mail-we0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751059AbaGKWJG (ORCPT ); Fri, 11 Jul 2014 18:09:06 -0400 MIME-Version: 1.0 In-Reply-To: <1405071325-14683-1-git-send-email-jaswinder.singh@linaro.org> References: <1405071167-14503-1-git-send-email-jaswinder.singh@linaro.org> <1405071325-14683-1-git-send-email-jaswinder.singh@linaro.org> Date: Fri, 11 Jul 2014 15:09:03 -0700 Message-ID: Subject: Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox From: Markus Mayer To: Jassi Brar Cc: Device Tree List , Linux Kernel Mailing List , Girish K S , Arnd Bergmann , Ian Campbell , Mark Rutland , Rob Herring , Pawel Moll , Courtney Cavin , Matt Porter , Craig McGeachie , LeyFoon Tan , Loic Pallardy , Suman Anna , ashwin.chaugule@linaro.org, bjorn@kryo.se, Patch Tracking , Mollie.Wu@tw.fujitsu.com, t.takinishi@jp.fujitsu.com Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11 July 2014 02:35, Jassi Brar wrote: > Introduce common framework for client/protocol drivers and > controller drivers of Inter-Processor-Communication (IPC). > > Client driver developers should have a look at > include/linux/mailbox_client.h to understand the part of > the API exposed to client drivers. > Similarly controller driver developers should have a look > at include/linux/mailbox_controller.h > > Signed-off-by: Jassi Brar > --- > .../devicetree/bindings/mailbox/mailbox.txt | 33 ++ > Documentation/mailbox.txt | 107 +++++ > MAINTAINERS | 8 + > drivers/mailbox/Makefile | 4 + > drivers/mailbox/mailbox.c | 490 +++++++++++++++++++++ > include/linux/mailbox_client.h | 48 ++ > include/linux/mailbox_controller.h | 128 ++++++ > 7 files changed, 818 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mailbox/mailbox.txt > create mode 100644 Documentation/mailbox.txt > create mode 100644 drivers/mailbox/mailbox.c > create mode 100644 include/linux/mailbox_client.h > create mode 100644 include/linux/mailbox_controller.h I don't think combining code and documentation like this is the right approach. As per Documentation/devicetree/bindings/submitting-patches.txt: "1) The Documentation/ portion of the patch should be a separate patch." I am not sure if binding document and regular documentation should be separated out or if they can stay together (those more knowledgeable, please comment!), but the code portion should definitely be a separate patch from the documentation. Regards, -Markus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/