Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751855AbaGLHRt (ORCPT ); Sat, 12 Jul 2014 03:17:49 -0400 Received: from mail-wg0-f51.google.com ([74.125.82.51]:43475 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751616AbaGLHRr (ORCPT ); Sat, 12 Jul 2014 03:17:47 -0400 MIME-Version: 1.0 In-Reply-To: <20140711194243.GA3131@himangi-Dell> References: <20140711194243.GA3131@himangi-Dell> From: Andreas Noever Date: Sat, 12 Jul 2014 09:17:25 +0200 Message-ID: Subject: Re: [PATCH] thunderbolt: Use kcalloc To: Himangi Saraogi , Greg Kroah-Hartman Cc: "linux-kernel@vger.kernel.org" , julia.lawall@lip6.fr Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 11, 2014 at 9:42 PM, Himangi Saraogi wrote: > The advantage of kcalloc is, that will prevent integer overflows > which could result from the multiplication of number of elements > and size and it is also a bit nicer to read. > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall > --- > A patch on top of my char-misc tree as the kzalloc version is > already applied there. > > drivers/thunderbolt/nhi.c | 10 ++++------ > 1 file changed, 4 insertions(+), 6 deletions(-) > > diff --git a/drivers/thunderbolt/nhi.c b/drivers/thunderbolt/nhi.c > index ce72f31..c68fe12 100644 > --- a/drivers/thunderbolt/nhi.c > +++ b/drivers/thunderbolt/nhi.c > @@ -569,12 +569,10 @@ static int nhi_probe(struct pci_dev *pdev, const struct pci_device_id *id) > nhi->hop_count); > INIT_WORK(&nhi->interrupt_work, nhi_interrupt_work); > > - nhi->tx_rings = devm_kzalloc(&pdev->dev, > - nhi->hop_count * sizeof(*nhi->tx_rings), > - GFP_KERNEL); > - nhi->rx_rings = devm_kzalloc(&pdev->dev, > - nhi->hop_count * sizeof(*nhi->rx_rings), > - GFP_KERNEL); > + nhi->tx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count, > + sizeof(*nhi->tx_rings), GFP_KERNEL); > + nhi->rx_rings = devm_kcalloc(&pdev->dev, nhi->hop_count, > + sizeof(*nhi->rx_rings), GFP_KERNEL); > if (!nhi->tx_rings || !nhi->rx_rings) > return -ENOMEM; > > -- > 1.9.1 > +Greg Acked-by: Andreas Noever -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/