Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbaGLLg7 (ORCPT ); Sat, 12 Jul 2014 07:36:59 -0400 Received: from mailrelay003.isp.belgacom.be ([195.238.6.53]:30364 "EHLO mailrelay003.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750783AbaGLLgc (ORCPT ); Sat, 12 Jul 2014 07:36:32 -0400 X-Belgacom-Dynamic: yes X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Al8KALscwVNXQ56W/2dsb2JhbABZgw6tMQEBAQEBAQUBbgGcAAGBDRd1hAQBBScvIxBROR4ZiEYBtEOSJxeFe4lQBxaELQEEmw6UHYNGOw From: Fabian Frederick To: linux-kernel@vger.kernel.org Cc: paulus@samba.org, benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org, Fabian Frederick Subject: [PATCH 4/7] powerpc/sysfs: replace sscanf by kstrtol Date: Sat, 12 Jul 2014 13:36:17 +0200 Message-Id: <1405164980-9525-5-git-send-email-fabf@skynet.be> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1405164980-9525-1-git-send-email-fabf@skynet.be> References: <1405164980-9525-1-git-send-email-fabf@skynet.be> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org See checkpatch warning "Prefer kstrto to single variable sscanf" Signed-off-by: Fabian Frederick --- arch/powerpc/kernel/sysfs.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/kernel/sysfs.c b/arch/powerpc/kernel/sysfs.c index 67fd2fd..4293e4f 100644 --- a/arch/powerpc/kernel/sysfs.c +++ b/arch/powerpc/kernel/sysfs.c @@ -43,12 +43,11 @@ static ssize_t store_smt_snooze_delay(struct device *dev, size_t count) { struct cpu *cpu = container_of(dev, struct cpu, dev); - ssize_t ret; long snooze; + int rc = kstrtol(buf, 0, &snooze); - ret = sscanf(buf, "%ld", &snooze); - if (ret != 1) - return -EINVAL; + if (rc) + return rc; per_cpu(smt_snooze_delay, cpu->dev.id) = snooze; return count; -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/