Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753124AbaGMJ17 (ORCPT ); Sun, 13 Jul 2014 05:27:59 -0400 Received: from mail-vc0-f173.google.com ([209.85.220.173]:36016 "EHLO mail-vc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752907AbaGMJ1r (ORCPT ); Sun, 13 Jul 2014 05:27:47 -0400 MIME-Version: 1.0 In-Reply-To: <201407130545.23004.marex@denx.de> References: <53C1F7DE.3060102@gmail.com> <201407130545.23004.marex@denx.de> Date: Sun, 13 Jul 2014 17:27:44 +0800 Message-ID: Subject: Re: [PATCH] drivers: Let several drivers depends on HAS_IOMEM for 'devm_ioremap_resource' From: Lennox Wu To: Marek Vasut Cc: Chen Gang , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , dmitry.torokhov@gmail.com, thierry.reding@gmail.com, jic23@kernel.org, wim@iguana.be, Benjamin Herrenschmidt , kys@microsoft.com, Martin Schwidefsky , teg@jklm.no, Mischa.Jonker@synopsys.com, msalter@redhat.com, lars@metafoo.de, Richard Weinberger , knaack.h@gmx.de, rdunlap@infradead.org, linux-input@vger.kernel.org, linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-watchdog@vger.kernel.org, Liqin Chen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org As I said before, some configurations don't make sense. I don't think all of the patches are necessary. Best, Lennox 2014-07-13 11:45 GMT+08:00 Marek Vasut : > On Sunday, July 13, 2014 at 05:07:10 AM, Chen Gang wrote: >> Several drivers need 'devm_ioremap_resource' which need HAS_IOMEM enabled. >> So let them depend on HAS_IOMEM. >> >> The related error (with allmodconfig under score): >> >> MODPOST 1365 modules >> ERROR: "devm_ioremap_resource" [drivers/watchdog/tegra_wdt.ko] undefined! >> ERROR: "devm_ioremap_resource" [drivers/watchdog/of_xilinx_wdt.ko] >> undefined! ERROR: "devm_ioremap_resource" >> [drivers/staging/iio/adc/mxs-lradc.ko] undefined! ERROR: >> "devm_ioremap_resource" [drivers/pwm/pwm-clps711x.ko] undefined! ERROR: >> "devm_ioremap_resource" [drivers/input/serio/olpc_apsp.ko] undefined! >> ERROR: "devm_ioremap_resource" [drivers/input/serio/arc_ps2.ko] undefined! > > This stuff should go through different trees, so I'd suggest to split this into > multiple patches. Thanks for catching this stuff ! > > Best regards, > Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/