Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbaGMTRR (ORCPT ); Sun, 13 Jul 2014 15:17:17 -0400 Received: from p3plex2out02.prod.phx3.secureserver.net ([184.168.131.14]:43425 "EHLO p3plex2out02.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751313AbaGMTRG convert rfc822-to-8bit (ORCPT ); Sun, 13 Jul 2014 15:17:06 -0400 From: Hartley Sweeten To: Chase Southwood , "gregkh@linuxfoundation.org" CC: "abbotti@mev.co.uk" , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice Thread-Topic: [PATCH 2/2] staging: comedi: addi_apci_1564: use addi_watchdog module to init watchdog subdevice Thread-Index: AQHPniLjmd9jMAfz+0KWcL43PQIqp5ueYVPn Date: Sun, 13 Jul 2014 19:17:03 +0000 Message-ID: References: <1405204956-1559-1-git-send-email-chase.southwood@gmail.com>,<1405205049-1828-1-git-send-email-chase.southwood@gmail.com> In-Reply-To: <1405205049-1828-1-git-send-email-chase.southwood@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [24.251.30.167] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday, July 12, 2014 3:44 PM, Chase Southwood wrote: > Use the addi_watchdog module to provide support for the watchdog > subdevice. > > Also, rearrange the subdevice init blocks so that the order makes sense. > Digital input/output subdevices and subdevices for DI/DO interrupt > support, followed by timer/counter/watchdog subdevices is the new order. > > Signed-off-by: Chase Southwood > Cc: Ian Abbott > Cc: H Hartley Sweeten > --- > drivers/staging/comedi/drivers/addi_apci_1564.c | 34 +++++++++++++++---------- > 1 file changed, 20 insertions(+), 14 deletions(-) Chase, You should also add the dependency for the addi watchdog module to the Kconfig. Regards, Hartley -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/