Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752728AbaGNE4c (ORCPT ); Mon, 14 Jul 2014 00:56:32 -0400 Received: from mail-qa0-f51.google.com ([209.85.216.51]:61821 "EHLO mail-qa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750875AbaGNE4X (ORCPT ); Mon, 14 Jul 2014 00:56:23 -0400 MIME-Version: 1.0 In-Reply-To: References: <1405071167-14503-1-git-send-email-jaswinder.singh@linaro.org> <1405071325-14683-1-git-send-email-jaswinder.singh@linaro.org> Date: Mon, 14 Jul 2014 10:26:22 +0530 Message-ID: Subject: Re: [PATCHv8 2/2] mailbox: Introduce framework for mailbox From: Jassi Brar To: Markus Mayer Cc: Device Tree List , Linux Kernel Mailing List , Girish K S , Arnd Bergmann , Ian Campbell , Mark Rutland , Rob Herring , Pawel Moll , Courtney Cavin , Matt Porter , Craig McGeachie , LeyFoon Tan , Loic Pallardy , Suman Anna , Ashwin Chaugule , Bjorn Andersson , Patch Tracking , "Mollie.Wu" , Tetsuya Takinishi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12 July 2014 03:39, Markus Mayer wrote: > On 11 July 2014 02:35, Jassi Brar wrote: >> Introduce common framework for client/protocol drivers and >> controller drivers of Inter-Processor-Communication (IPC). >> >> Client driver developers should have a look at >> include/linux/mailbox_client.h to understand the part of >> the API exposed to client drivers. >> Similarly controller driver developers should have a look >> at include/linux/mailbox_controller.h >> >> Signed-off-by: Jassi Brar >> --- >> .../devicetree/bindings/mailbox/mailbox.txt | 33 ++ >> Documentation/mailbox.txt | 107 +++++ >> MAINTAINERS | 8 + >> drivers/mailbox/Makefile | 4 + >> drivers/mailbox/mailbox.c | 490 +++++++++++++++++++++ >> include/linux/mailbox_client.h | 48 ++ >> include/linux/mailbox_controller.h | 128 ++++++ >> 7 files changed, 818 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/mailbox/mailbox.txt >> create mode 100644 Documentation/mailbox.txt >> create mode 100644 drivers/mailbox/mailbox.c >> create mode 100644 include/linux/mailbox_client.h >> create mode 100644 include/linux/mailbox_controller.h > > I don't think combining code and documentation like this is the right > approach. As per > Documentation/devicetree/bindings/submitting-patches.txt: > > "1) The Documentation/ portion of the patch should be a separate patch." > Thanks, in fact the previous revision was split like that. But encouraged by seeing many other instances, I took the liberty to club them together because neither part makes sense without the other. Also any reviewer looking at one has to look at the other too. > I am not sure if binding document and regular documentation should be > separated out or if they can stay together (those more knowledgeable, > please comment!), but the code portion should definitely be a separate > patch from the documentation. > I am willing to learn and split the patchset again, if the gods want so.. Cheers, Jassi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/