Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753138AbaGNGNb (ORCPT ); Mon, 14 Jul 2014 02:13:31 -0400 Received: from mail-oa0-f54.google.com ([209.85.219.54]:34859 "EHLO mail-oa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753039AbaGNGNY (ORCPT ); Mon, 14 Jul 2014 02:13:24 -0400 MIME-Version: 1.0 In-Reply-To: <53C0A648.9080909@codeaurora.org> References: <1404959850-11617-1-git-send-email-skannan@codeaurora.org> <1405052287-4744-1-git-send-email-skannan@codeaurora.org> <53C0A648.9080909@codeaurora.org> Date: Mon, 14 Jul 2014 11:43:24 +0530 Message-ID: Subject: Re: [PATCH v2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend From: Viresh Kumar To: Saravana Kannan Cc: "Rafael J . Wysocki" , Todd Poynor , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Stephen Boyd Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12 July 2014 08:36, Saravana Kannan wrote: > On 07/10/2014 11:19 PM, Viresh Kumar wrote: > >> >> Please make sure you take care of these issues: >> - suspend/resume >> - hotplug >> - module insert/remove > > Ok, I was just at the current code. Does cpufreq_unregister_driver() even > really work correctly as it stands? > > It doesn't even seem to stop any of the governors/policies before it just > set the cpufreq_driver pointer to NULL. > > So, technically my v2 patch doesn't even make anything worse when it comes > to unregistering the cpufreq driver. Are you really sure about this? I have tested this *myself* earlier.. subsys_interface_unregister() should take care of stopping/freeing governor stuff.. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/