Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751995AbaGNGTc (ORCPT ); Mon, 14 Jul 2014 02:19:32 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:57307 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751506AbaGNGTZ (ORCPT ); Mon, 14 Jul 2014 02:19:25 -0400 Message-ID: <53C3763D.3040405@ti.com> Date: Mon, 14 Jul 2014 11:48:37 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0 MIME-Version: 1.0 To: Heikki Krogerus CC: Greg Kroah-Hartman , Felipe Balbi , Vivek Gautam , , , Tony Lindgren Subject: Re: [PATCHv2 3/6] arm: omap3: twl: use the new lookup method with usb phy References: <1401972778-5880-1-git-send-email-heikki.krogerus@linux.intel.com> <1401972778-5880-4-git-send-email-heikki.krogerus@linux.intel.com> In-Reply-To: <1401972778-5880-4-git-send-email-heikki.krogerus@linux.intel.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tony, On Thursday 05 June 2014 06:22 PM, Heikki Krogerus wrote: > Provide complete association for the phy and it's user > (musb) with the new phy lookup method. I can take this patch with your Ack or if you want to take it Acked-by: Kishon Vijay Abraham I Thanks Kishon > > Signed-off-by: Heikki Krogerus > Cc: Tony Lindgren > --- > arch/arm/mach-omap2/twl-common.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/arch/arm/mach-omap2/twl-common.c b/arch/arm/mach-omap2/twl-common.c > index b0d54da..b78383c 100644 > --- a/arch/arm/mach-omap2/twl-common.c > +++ b/arch/arm/mach-omap2/twl-common.c > @@ -91,18 +91,14 @@ void __init omap_pmic_late_init(void) > } > > #if defined(CONFIG_ARCH_OMAP3) > -struct phy_consumer consumers[] = { > - PHY_CONSUMER("musb-hdrc.0", "usb"), > -}; > - > -struct phy_init_data init_data = { > - .consumers = consumers, > - .num_consumers = ARRAY_SIZE(consumers), > +static struct phy_lookup twl4030_usb_lookup = { > + .phy_name = "phy-twl4030_usb.0", > + .dev_id = "musb-hdrc.0", > + .con_id = "usb", > }; > > static struct twl4030_usb_data omap3_usb_pdata = { > - .usb_mode = T2_USB_MODE_ULPI, > - .init_data = &init_data, > + .usb_mode = T2_USB_MODE_ULPI, > }; > > static int omap3_batt_table[] = { > @@ -225,8 +221,10 @@ void __init omap3_pmic_get_config(struct twl4030_platform_data *pmic_data, > } > > /* Common platform data configurations */ > - if (pdata_flags & TWL_COMMON_PDATA_USB && !pmic_data->usb) > + if (pdata_flags & TWL_COMMON_PDATA_USB && !pmic_data->usb) { > + phy_register_lookup(&twl4030_usb_lookup); > pmic_data->usb = &omap3_usb_pdata; > + } > > if (pdata_flags & TWL_COMMON_PDATA_BCI && !pmic_data->bci) > pmic_data->bci = &omap3_bci_pdata; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/