Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754551AbaGNLZG (ORCPT ); Mon, 14 Jul 2014 07:25:06 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:43228 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbaGNLZC (ORCPT ); Mon, 14 Jul 2014 07:25:02 -0400 MIME-Version: 1.0 In-Reply-To: <1405332522-6162-1-git-send-email-sachin.kamat@samsung.com> References: <1405332522-6162-1-git-send-email-sachin.kamat@samsung.com> Date: Mon, 14 Jul 2014 16:55:00 +0530 X-Google-Sender-Auth: K5D0gC0pyqM6BEmAbLGlqTr80pg Message-ID: Subject: Re: [PATCH v3 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs From: Vivek Gautam To: Sachin Kamat Cc: "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , kishon , Doug Anderson , Sachin Kamat Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 14, 2014 at 3:38 PM, Sachin Kamat wrote: > Since the USB 2.0 PHYs are required with EHCI/OHCI USB drivers and > USB gadget controller supported by the DWC2 gadget driver, make it > depend on them and default to ARCH_EXYNOS as they are meant for > Exynos platforms. Also, make the sub-drivers silent options enabling > them based on the SoC platforms that they are meant to work with. This > will make life easier for end users who do not have any way knowing the > dependencies. > > Signed-off-by: Sachin Kamat > Reviewed-by: Jingoo Han > --- > Changes since v3: > * Rebased the series on top of latest PHY tree [1]. > [1] git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git > --- > drivers/phy/Kconfig | 35 +++++++++++------------------------ > 1 file changed, 11 insertions(+), 24 deletions(-) > > diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig > index 5fceb33..c412ca4 100644 > --- a/drivers/phy/Kconfig > +++ b/drivers/phy/Kconfig > @@ -132,43 +132,30 @@ config PHY_SUN4I_USB > config PHY_SAMSUNG_USB2 > tristate "Samsung USB 2.0 PHY driver" > depends on HAS_IOMEM > + depends on USB_EHCI_EXYNOS || USB_OHCI_EXYNOS || USB_DWC2 > select GENERIC_PHY > select MFD_SYSCON > + default ARCH_EXYNOS > help > Enable this to support the Samsung USB 2.0 PHY driver for Samsung > - SoCs. This driver provides the interface for USB 2.0 PHY. Support for > - particular SoCs has to be enabled in addition to this driver. Number > - and type of supported phys depends on the SoC. > + SoCs. This driver provides the interface for USB 2.0 PHY. Support > + for particular PHYs will be enabled based on the SoC type in addition > + to this driver. > > config PHY_EXYNOS4210_USB2 > - bool "Support for Exynos 4210" > + bool > depends on PHY_SAMSUNG_USB2 > - depends on CPU_EXYNOS4210 > - help > - Enable USB PHY support for Exynos 4210. This option requires that > - Samsung USB 2.0 PHY driver is enabled and means that support for this > - particular SoC is compiled in the driver. In case of Exynos 4210 four > - phys are available - device, host, HSIC0 and HSIC1. > + default CPU_EXYNOS4210 > > config PHY_EXYNOS4X12_USB2 > - bool "Support for Exynos 3250/4x12" > + bool > depends on PHY_SAMSUNG_USB2 > - depends on (SOC_EXYNOS3250 || SOC_EXYNOS4212 || SOC_EXYNOS4412) > - help > - Enable USB PHY support for Exynos 3250/4x12. This option requires > - that Samsung USB 2.0 PHY driver is enabled and means that support for > - this particular SoC is compiled in the driver. In case of Exynos 4x12 > - four phys are available - device, host, HSIC0 and HSIC1. > + default SOC_EXYNOS3250 || SOC_EXYNOS4212 || SOC_EXYNOS4412 > > config PHY_EXYNOS5250_USB2 > - bool "Support for Exynos 5250" > + bool > depends on PHY_SAMSUNG_USB2 > - depends on SOC_EXYNOS5250 > - help > - Enable USB PHY support for Exynos 5250. This option requires that > - Samsung USB 2.0 PHY driver is enabled and means that support for this > - particular SoC is compiled in the driver. In case of Exynos 5250 four > - phys are available - device, host, HSIC0 and HSIC. > + default SOC_EXYNOS5250 || SOC_EXYNOS5420 > > config PHY_EXYNOS5_USBDRD > tristate "Exynos5 SoC series USB DRD PHY driver" > -- > 1.7.9.5 > Tested on Exynos5800 and Exynos5250, with exynos_defconfig patch : http://www.spinics.net/lists/linux-samsung-soc/msg33994.html Tested-by: Vivek Gautam -- Best Regards Vivek Gautam Samsung R&D Institute, Bangalore India -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/