Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755400AbaGNOCL (ORCPT ); Mon, 14 Jul 2014 10:02:11 -0400 Received: from gloria.sntech.de ([95.129.55.99]:39395 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754541AbaGNOCA (ORCPT ); Mon, 14 Jul 2014 10:02:00 -0400 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: suravee.suthikulpanit@amd.com, jason@lakedaemon.net Cc: linux-arm-kernel@lists.infradead.org, marc.zyngier@arm.com, mark.rutland@arm.com, devicetree@vger.kernel.org, pawel.moll@arm.com, linux-doc@vger.kernel.org, Catalin.Marinas@arm.com, Harish.Kasiviswanathan@amd.com, linux-kernel@vger.kernel.org, Will.Deacon@arm.com, Suravee Suthikulpanit , linux-pci@vger.kernel.org, tglx@linutronix.de Subject: Re: [PATCH 1/4 V3] irqchip: gic: Add binding probe for ARM GIC400 Date: Mon, 14 Jul 2014 16:03:15 +0200 Message-ID: <2932284.F1eaAf8ArJ@diego> User-Agent: KMail/4.11.5 (Linux/3.13-1-amd64; KDE/4.11.3; x86_64; ; ) In-Reply-To: <1404947104-21345-2-git-send-email-suravee.suthikulpanit@amd.com> References: <1404947104-21345-1-git-send-email-suravee.suthikulpanit@amd.com> <1404947104-21345-2-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 9. Juli 2014, 18:05:01 schrieb suravee.suthikulpanit@amd.com: > From: Suravee Suthikulpanit > > Add new Irqchip declaration for GIC400. This was mentioned in > gic binding documentation, but there is not code to support it. > > Signed-off-by: Suravee Suthikulpanit The Rockchip RK3288 also contains a GIC400, so I would be very happy if someone could pick up this one patch independently of the rest. But in light of Matthias' cortex-a7-gic patch from last week, this one might need an update. > --- > drivers/irqchip/irq-gic.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c > index 508b815..ac8f7ea 100644 > --- a/drivers/irqchip/irq-gic.c > +++ b/drivers/irqchip/irq-gic.c > @@ -1020,6 +1020,8 @@ gic_of_init(struct device_node *node, struct > device_node *parent) gic_cnt++; > return 0; > } > + also it looks like the omission of the blank line in the original file is intentional, so I'd guess it shouldn't be added here. > +IRQCHIP_DECLARE(arm_gic_400, "arm,gic-400", gic_of_init); > IRQCHIP_DECLARE(cortex_a15_gic, "arm,cortex-a15-gic", gic_of_init); > IRQCHIP_DECLARE(cortex_a9_gic, "arm,cortex-a9-gic", gic_of_init); > IRQCHIP_DECLARE(msm_8660_qgic, "qcom,msm-8660-qgic", gic_of_init); Thanks Heiko -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/