Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756794AbaGNTFE (ORCPT ); Mon, 14 Jul 2014 15:05:04 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:64756 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754847AbaGNTEz (ORCPT ); Mon, 14 Jul 2014 15:04:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <1405017631-27346-1-git-send-email-keescook@chromium.org> <20140711164931.GA18473@redhat.com> From: Andy Lutomirski Date: Mon, 14 Jul 2014 12:04:33 -0700 Message-ID: Subject: Re: [PATCH v10 0/11] seccomp: add thread sync ability To: Kees Cook Cc: Oleg Nesterov , LKML , Alexei Starovoitov , "Michael Kerrisk (man-pages)" , Andrew Morton , Daniel Borkmann , Will Drewry , Julien Tinnes , David Drysdale , Linux API , "x86@kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mips@linux-mips.org, linux-arch , linux-security-module Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 11, 2014 at 10:55 AM, Kees Cook wrote: > On Fri, Jul 11, 2014 at 9:49 AM, Oleg Nesterov wrote: >> On 07/10, Kees Cook wrote: >>> >>> This adds the ability for threads to request seccomp filter >>> synchronization across their thread group (at filter attach time). >>> For example, for Chrome to make sure graphic driver threads are fully >>> confined after seccomp filters have been attached. >>> >>> To support this, locking on seccomp changes via thread-group-shared >>> sighand lock is introduced, along with refactoring of no_new_privs. Races >>> with thread creation are handled via delayed duplication of the seccomp >>> task struct field and cred_guard_mutex. >>> >>> This includes a new syscall (instead of adding a new prctl option), >>> as suggested by Andy Lutomirski and Michael Kerrisk. >> >> I do not not see any problems in this version, > > Awesome! Thank you for all the reviews. :) If Andy and Michael are > happy with this too, I think this is in good shape. \o/ I think I'm happy with it. Is it in git somewhere for easy perusal? I have a cold, so my reviewing ability is a bit off, but I want to take a look at the final version, and git is a little easier than email for this. --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/