Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756640AbaGNTKb (ORCPT ); Mon, 14 Jul 2014 15:10:31 -0400 Received: from smtp.codeaurora.org ([198.145.11.231]:59739 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754271AbaGNTKX (ORCPT ); Mon, 14 Jul 2014 15:10:23 -0400 Message-ID: <53C42B1D.8070301@codeaurora.org> Date: Mon, 14 Jul 2014 12:10:21 -0700 From: Saravana Kannan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Viresh Kumar CC: "Rafael J . Wysocki" , Todd Poynor , "linux-pm@vger.kernel.org" , Linux Kernel Mailing List , "linux-arm-msm@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Stephen Boyd Subject: Re: [PATCH v2] cpufreq: Don't destroy/realloc policy/sysfs on hotplug/suspend References: <1404959850-11617-1-git-send-email-skannan@codeaurora.org> <1405052287-4744-1-git-send-email-skannan@codeaurora.org> <53C0A648.9080909@codeaurora.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/13/2014 11:13 PM, Viresh Kumar wrote: > On 12 July 2014 08:36, Saravana Kannan wrote: >> On 07/10/2014 11:19 PM, Viresh Kumar wrote: >> >>> >>> Please make sure you take care of these issues: >>> - suspend/resume >>> - hotplug >>> - module insert/remove >> >> Ok, I was just at the current code. Does cpufreq_unregister_driver() even >> really work correctly as it stands? >> >> It doesn't even seem to stop any of the governors/policies before it just >> set the cpufreq_driver pointer to NULL. >> >> So, technically my v2 patch doesn't even make anything worse when it comes >> to unregistering the cpufreq driver. > > Are you really sure about this? I have tested this *myself* earlier.. > > subsys_interface_unregister() should take care of stopping/freeing governor > stuff.. > I was asking this question based on looking at the code. Didn't actually try it -- sent it just before being done for the day. I didn't know about the subsys_interface_unregister() coming into play here. I'll take a look. Thanks for the pointer. -Saravana -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/