Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757334AbaGNVCW (ORCPT ); Mon, 14 Jul 2014 17:02:22 -0400 Received: from senator.holtmann.net ([87.106.208.187]:33764 "EHLO mail.holtmann.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756215AbaGNVCT (ORCPT ); Mon, 14 Jul 2014 17:02:19 -0400 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] Bluetooth: cmtp: Remove unnecessary null test From: Marcel Holtmann In-Reply-To: <20140714203412.GA16532@himangi-Dell> Date: Mon, 14 Jul 2014 23:02:26 +0200 Cc: "Gustavo F. Padovan" , Johan Hedberg , "David S. Miller" , Linux Bluetooth mailing list , Network Development , linux-kernel@vger.kernel.org, julia.lawall@lip6.fr Content-Transfer-Encoding: 7bit Message-Id: References: <20140714203412.GA16532@himangi-Dell> To: Himangi Saraogi X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Himangi, > This patch removes the null test on ctrl. ctrl is initialized at the > beginning of the function to &session->ctrl. Since session is > dereferenced prior to the null test, session must be a valid pointer, > and &session->ctrl cannot be null. > > The following Coccinelle script is used for detecting the change: > > @r@ > expression e,f; > identifier g,y; > statement S1,S2; > @@ > > *e = &f->g > <+... > f->y > ...+> > *if (e != NULL || ...) > S1 else S2 > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall > --- > net/bluetooth/cmtp/capi.c | 6 ------ > 1 file changed, 6 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/