Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757293AbaGNVqk (ORCPT ); Mon, 14 Jul 2014 17:46:40 -0400 Received: from canardo.mork.no ([148.122.252.1]:54339 "EHLO canardo.mork.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756890AbaGNVqi convert rfc822-to-8bit (ORCPT ); Mon, 14 Jul 2014 17:46:38 -0400 From: =?utf-8?Q?Bj=C3=B8rn_Mork?= To: Linus Torvalds Cc: Hans de Goede , Linux Kernel Mailing List , Linux ACPI , "Rafael J. Wysocki" Subject: Re: [BISECTED 3.16-rc REGREGRESSION] backlight control stopped working Organization: m References: <87pph8kse7.fsf@nemi.mork.no> <53C3D7C3.7090505@redhat.com> <877g3fsm98.fsf@nemi.mork.no> Date: Mon, 14 Jul 2014 23:46:22 +0200 In-Reply-To: (Linus Torvalds's message of "Mon, 14 Jul 2014 13:49:10 -0700") Message-ID: <8761iztxzl.fsf@nemi.mork.no> User-Agent: Gnus/5.130011 (Ma Gnus v0.11) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds writes: > On Mon, Jul 14, 2014 at 1:45 PM, Bjørn Mork wrote: >>> brightness change from user mode comes in during that delay, we cancel >>> the kernel-induced pending change. >> >> That sounds like a good solution to me FWIW. > > Try the patch. It *might* work. I'm not saying it will, but it seemed > to at least compile for me. Yes, the patch works as advertised for me. Thanks. But this will break existing configs: > --- a/drivers/acpi/video.c > +++ b/drivers/acpi/video.c > @@ -68,8 +68,8 @@ MODULE_AUTHOR("Bruno Ducrot"); > MODULE_DESCRIPTION("ACPI Video Driver"); > MODULE_LICENSE("GPL"); > > -static bool brightness_switch_enabled; > -module_param(brightness_switch_enabled, bool, 0644); > +static int brightness_switch_enabled = -1; > +module_param(brightness_switch_enabled, int, 0644); > > /* > * By default, we don't allow duplicate ACPI video bus devices Any setup using e.g "options video brightness_switch_enabled=Y" will barf on this, won't they? Bjørn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/