Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757386AbaGNWIk (ORCPT ); Mon, 14 Jul 2014 18:08:40 -0400 Received: from mail-ob0-f169.google.com ([209.85.214.169]:36187 "EHLO mail-ob0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757000AbaGNWIi (ORCPT ); Mon, 14 Jul 2014 18:08:38 -0400 MIME-Version: 1.0 In-Reply-To: <20140714192451.GC5803@tassilo.jf.intel.com> References: <1405123285-23544-1-git-send-email-andi@firstfloor.org> <1405123285-23544-2-git-send-email-andi@firstfloor.org> <20140714192451.GC5803@tassilo.jf.intel.com> Date: Tue, 15 Jul 2014 00:08:37 +0200 Message-ID: Subject: Re: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store From: Stephane Eranian To: Andi Kleen Cc: Andi Kleen , Peter Zijlstra , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andi, On Mon, Jul 14, 2014 at 9:24 PM, Andi Kleen wrote: >> You could do better if you tagged the event during setup as load vs. store. >> And then you could simply propagate the flag to the data source struct. > > This would require listing all PEBS events in the table again. > The whole point of the other patch was to get rid of that. > > Besides it wouldn't work for a range of events (like UOPS_RETIRED.ALL) > I have a problem with this patch. It makes: perf mem -t store rec record OP_NA for the store. It was recording OP_STORE before. I think we need to keep LD/ST info. This is useful for analysis especially if we collect loads/stores simultaneously. Was working before for the mem-loads, mem-stores events. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/