Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757576AbaGNWua (ORCPT ); Mon, 14 Jul 2014 18:50:30 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:65184 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757251AbaGNWu1 (ORCPT ); Mon, 14 Jul 2014 18:50:27 -0400 MIME-Version: 1.0 In-Reply-To: References: <1405123285-23544-1-git-send-email-andi@firstfloor.org> <1405123285-23544-2-git-send-email-andi@firstfloor.org> <20140714192451.GC5803@tassilo.jf.intel.com> <20140714223918.GE5803@tassilo.jf.intel.com> Date: Tue, 15 Jul 2014 00:50:27 +0200 Message-ID: Subject: Re: [PATCH 2/2] perf, x86: Don't mark DataLA addresses as store From: Stephane Eranian To: Andi Kleen Cc: Andi Kleen , Peter Zijlstra , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 15, 2014 at 12:49 AM, Stephane Eranian wrote: > On Tue, Jul 15, 2014 at 12:39 AM, Andi Kleen wrote: >>> I have a problem with this patch. >>> >>> It makes: perf mem -t store rec record OP_NA for the store. >>> It was recording OP_STORE before. >>> >>> I think we need to keep LD/ST info. This is useful for analysis >>> especially if we collect loads/stores simultaneously. >>> >>> Was working before for the mem-loads, mem-stores events. >> >> Ok. Would it be enough if it only worked for "mem-stores" and not >> all PEBS events? >> > Ok, do that at a minimum. > But if I recall the PEBS stores events were not that many to begin with. >> Otherwise have to go back to an even larger PEBS constraint >> table for HSW than before. >> >> -Andi >> >> -- >> ak@linux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/