Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755223AbaGOByI (ORCPT ); Mon, 14 Jul 2014 21:54:08 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:32001 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753506AbaGOByG (ORCPT ); Mon, 14 Jul 2014 21:54:06 -0400 Message-ID: <53C48986.5010109@oracle.com> Date: Tue, 15 Jul 2014 11:53:10 +1000 From: James Morris User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Kees Cook CC: Oleg Nesterov , LKML , Andy Lutomirski , Alexei Starovoitov , "Michael Kerrisk (man-pages)" , Andrew Morton , Daniel Borkmann , Will Drewry , Julien Tinnes , David Drysdale , Linux API , "x86@kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mips@linux-mips.org, linux-arch , linux-security-module Subject: Re: [PATCH v10 0/11] seccomp: add thread sync ability References: <1405017631-27346-1-git-send-email-keescook@chromium.org> <20140711164931.GA18473@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Source-IP: acsinet22.oracle.com [141.146.126.238] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/15/2014 04:59 AM, Kees Cook wrote: > Hi James, > > Is this series something you would carry in the security-next tree? > That has traditionally been where seccomp features have landed in the > past. > > -Kees > > > On Fri, Jul 11, 2014 at 10:55 AM, Kees Cook wrote: >> On Fri, Jul 11, 2014 at 9:49 AM, Oleg Nesterov wrote: >>> On 07/10, Kees Cook wrote: >>>> >>>> This adds the ability for threads to request seccomp filter >>>> synchronization across their thread group (at filter attach time). >>>> For example, for Chrome to make sure graphic driver threads are fully >>>> confined after seccomp filters have been attached. >>>> >>>> To support this, locking on seccomp changes via thread-group-shared >>>> sighand lock is introduced, along with refactoring of no_new_privs. Races >>>> with thread creation are handled via delayed duplication of the seccomp >>>> task struct field and cred_guard_mutex. >>>> >>>> This includes a new syscall (instead of adding a new prctl option), >>>> as suggested by Andy Lutomirski and Michael Kerrisk. >>> >>> I do not not see any problems in this version, >> >> Awesome! Thank you for all the reviews. :) If Andy and Michael are >> happy with this too, I think this is in good shape. \o/ >> >> -Kees >> >>> >>> Reviewed-by: Oleg Nesterov >>> >> >> >> >> -- >> Kees Cook >> Chrome OS Security > > > Yep, certainly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/