Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758137AbaGOIz0 (ORCPT ); Tue, 15 Jul 2014 04:55:26 -0400 Received: from g4t3427.houston.hp.com ([15.201.208.55]:40635 "EHLO g4t3427.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757584AbaGOIzV (ORCPT ); Tue, 15 Jul 2014 04:55:21 -0400 Message-ID: <53C4EC23.4060309@hp.com> Date: Tue, 15 Jul 2014 16:53:55 +0800 From: "Li, ZhenHua" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Heinrich Schuchardt CC: "Yann E. MORIN" , "linux-kbuild@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig References: <1404098187-9638-1-git-send-email-zhen-hual@hp.com> <53B1982F.4030504@gmx.de> <1267BB84A242B24E81E0C0C8955CFFC061A30C1D@G9W0343.americas.hpqcorp.net> <53C40589.8050202@gmx.de> In-Reply-To: <53C40589.8050202@gmx.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Heinrich, Thank you very much for reviewing. But seems the maintainer will not accept it. Zhenhua On 07/15/2014 12:30 AM, Heinrich Schuchardt wrote: > On 01.07.2014 01:10, Li, Zhen-Hua wrote: >> When malloc for jump, >> if (head && location) { >> jump = xmalloc(sizeof(struct jump_key)); >> .... >> } >> And here it is used: >> if (head && location && menu == location) >> jump->offset = strlen(r->s); >> >> >> So I think when jump is used, it must not be NULL; then !=NULL is not >> needed. > > I tested the patch against v13.6-rc5. It fixes the problem with the > warning. > > You can add > > Reviewed-by: Heinrich Schuchardt > > Best regards > > Heinrich > > >> -----Original Message----- >> From: Heinrich Schuchardt [mailto:xypron.glpk@gmx.de] >> Sent: Tuesday, July 01, 2014 1:03 AM >> To: Li, Zhen-Hua; Yann E. MORIN; linux-kbuild@vger.kernel.org; >> linux-kernel@vger.kernel.org >> Subject: Re: [PATCH 1/1] script/kconfig: remove a warning for menucofig >> >> On 30.06.2014 05:16, Li, Zhen-Hua wrote: >>> There is a warning when run "make menuconfig". >>> >>> scripts/kconfig/menu.c: In function ‘get_symbol_str’: >>> scripts/kconfig/menu.c:591:18: warning: ‘jump’ may be used >>> uninitialized in >>> this function [-Wmaybe-uninitialized] >>> jump->offset = strlen(r->s); >>> ^ >>> scripts/kconfig/menu.c:551:19: note: ‘jump’ was declared here >>> struct jump_key *jump; >>> ^ >>> >>> It is because the compiler think "jump" is not initialized, though >>> in fact >>> it is already initialized. >>> >>> Signed-off-by: Li, Zhen-Hua >>> --- >>> scripts/kconfig/menu.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/scripts/kconfig/menu.c b/scripts/kconfig/menu.c >>> index a26cc5d..584e0fc 100644 >>> --- a/scripts/kconfig/menu.c >>> +++ b/scripts/kconfig/menu.c >>> @@ -548,7 +548,7 @@ static void get_prompt_str(struct gstr *r, >>> struct property *prop, >>> { >>> int i, j; >>> struct menu *submenu[8], *menu, *location = NULL; >>> - struct jump_key *jump; >>> + struct jump_key *jump = NULL; >>> >>> str_printf(r, _("Prompt: %s\n"), _(prop->text)); >>> menu = prop->menu->parent; >>> >> Hello Zhen-Hua, >> >> the patch looks incomplete to me. A check >> jump != NULL >> should be added before accessing parts of structure jump_key. >> >> Best regards >> >> Heinrich Schuchardt >> > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/