Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758453AbaGOJcn (ORCPT ); Tue, 15 Jul 2014 05:32:43 -0400 Received: from fw-tnat.austin.arm.com ([217.140.110.23]:48640 "EHLO collaborate-mta1.arm.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758432AbaGOJcl (ORCPT ); Tue, 15 Jul 2014 05:32:41 -0400 Date: Tue, 15 Jul 2014 10:32:34 +0100 From: Morten Rasmussen To: Vincent Guittot Cc: Peter Zijlstra , Ingo Molnar , linux-kernel , Russell King - ARM Linux , LAK , Preeti U Murthy , Mike Galbraith , Nicolas Pitre , "linaro-kernel@lists.linaro.org" , Daniel Lezcano , Dietmar Eggemann Subject: Re: [PATCH v3 09/12] Revert "sched: Put rq's sched_avg under CONFIG_FAIR_GROUP_SCHED" Message-ID: <20140715093234.GA8700@e103034-lin> References: <1404144343-18720-1-git-send-email-vincent.guittot@linaro.org> <1404144343-18720-10-git-send-email-vincent.guittot@linaro.org> <20140710131646.GB3935@laptop> <20140711161344.GD26542@e103034-lin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 15, 2014 at 10:27:19AM +0100, Vincent Guittot wrote: > On 11 July 2014 18:13, Morten Rasmussen wrote: > > [snip] > > > > > In this example using rq->avg leads to imbalance whereas unweighted load > > would not. Correct me if I missed anything. > > You just miss to take into account how the imbalance is computed I don't think so. I'm aware that the imbalance is calculated based on the runnable_load_avg of the cpus. But if you pick the wrong cpus to compare to begin with, it doesn't matter. Morten -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/