Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932583AbaGOSCs (ORCPT ); Tue, 15 Jul 2014 14:02:48 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:44958 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbaGOSCp (ORCPT ); Tue, 15 Jul 2014 14:02:45 -0400 Message-ID: <53C56CBF.1020500@samsung.com> Date: Wed, 16 Jul 2014 03:02:39 +0900 From: Kukjin Kim User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.24) Gecko/20111108 Fedora/3.1.16-1.fc14 Lightning/1.0b3pre Thunderbird/3.1.16 MIME-Version: 1.0 To: Tomasz Figa CC: Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, "'Marek Szyprowski'" , "'Tomasz Figa'" Subject: Re: [PATCH 4/6] ARM: SAMSUNG: Restore Samsung PM Debug functionality References: <1403618235-19353-1-git-send-email-t.figa@samsung.com> <1403618235-19353-5-git-send-email-t.figa@samsung.com> <033901cf9ab3$44c469a0$ce4d3ce0$@samsung.com> <53BBF7FF.6050105@samsung.com> In-Reply-To: <53BBF7FF.6050105@samsung.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/14 22:54, Tomasz Figa wrote: > On 08.07.2014 15:48, Kukjin Kim wrote: >> Tomasz Figa wrote: >>> >>> Due to recently merged patches and previous merge conflicts, the Samsung >>> PM Debug functionality no longer can be enabled. This patch fixes >>> incorrect dependency of SAMSUNG_PM_DEBUG on an integer symbol and adds >>> missing header inclusion. >>> >> Yes, you're right and it should be fixed...but I have comments... >> >>> Signed-off-by: Tomasz Figa >>> --- >>> arch/arm/plat-samsung/Kconfig | 8 +++++++- >>> arch/arm/plat-samsung/pm-debug.c | 1 + >>> 2 files changed, 8 insertions(+), 1 deletion(-) >>> >>> diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig >>> index 301b892..483c959 100644 >>> --- a/arch/arm/plat-samsung/Kconfig >>> +++ b/arch/arm/plat-samsung/Kconfig >>> @@ -412,9 +412,14 @@ config S5P_DEV_MFC >>> >>> comment "Power management" >>> >>> +config HAVE_SAMSUNG_PM_DEBUG >>> + bool >>> + help >>> + Allow compilation of Samsung PM debugging code. >>> + >>> config SAMSUNG_PM_DEBUG >>> bool "S3C2410 PM Suspend debug" >>> - depends on PM&& DEBUG_KERNEL&& DEBUG_S3C_UART >>> + depends on PM&& DEBUG_KERNEL&& HAVE_SAMSUNG_PM_DEBUG >>> help >>> Say Y here if you want verbose debugging from the PM Suspend and >>> Resume code. See >>> @@ -484,6 +489,7 @@ config S5P_SLEEP >>> >>> config DEBUG_S3C_UART >>> depends on PLAT_SAMSUNG >>> + select HAVE_SAMSUNG_PM_DEBUG >> >> Hmm... >> >> The DEBUG_S3C_UART will be '0' when we select DEBUG_S3C_UART0, then the >> HAVE_SAMSUNG_PM_DEBUG will not be selected so SAMSUNG_PM_DEBUG is also... > > Yes, that's right. I posted v2 after a while in another reply to this > thread. > Any updates? Or I missed your updated? - Kukjin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/