Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933620AbaGOTpR (ORCPT ); Tue, 15 Jul 2014 15:45:17 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:51045 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933367AbaGOTpM (ORCPT ); Tue, 15 Jul 2014 15:45:12 -0400 Date: Tue, 15 Jul 2014 15:39:26 -0400 From: "John W. Linville" To: Tom Gundersen Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, David Miller , David Herrmann , Kay Sievers , Brett Rudley , Arend van Spriel , "Franky (Zhenhui) Lin" , Hante Meuleman , linux-wireless@vger.kernel.org, brcm80211-dev-list@broadcom.com Subject: Re: [PATCH v7 29/33] net: brcmfmac - set name assign type Message-ID: <20140715193926.GF26012@tuxdriver.com> References: <1404980258-30853-1-git-send-email-teg@jklm.no> <1404980258-30853-30-git-send-email-teg@jklm.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1404980258-30853-30-git-send-email-teg@jklm.no> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I don't seem to have a line with "NET_NAME_UNKNOWN" in this driver in any of my kernel trees. What tree are you using for development? On Thu, Jul 10, 2014 at 10:17:34AM +0200, Tom Gundersen wrote: > The name is given by the firmware, so we assume it is predictable. > > Signed-off-by: Tom Gundersen > Cc: Brett Rudley > Cc: Arend van Spriel > Cc: "Franky (Zhenhui) Lin" > Cc: Hante Meuleman > Cc: John Linville > Cc: linux-wireless@vger.kernel.org > Cc: brcm80211-dev-list@broadcom.com > --- > drivers/net/wireless/brcm80211/brcmfmac/fweh.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c > index f6990f2..8d32721 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/fweh.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/fweh.c > @@ -201,7 +201,8 @@ static void brcmf_fweh_handle_if_event(struct brcmf_pub *drvr, > brcmf_dbg(EVENT, "adding %s (%pM)\n", emsg->ifname, > emsg->addr); > ifp = brcmf_add_if(drvr, ifevent->bssidx, ifevent->ifidx, > - emsg->ifname, NET_NAME_UNKNOWN, emsg->addr); > + emsg->ifname, NET_NAME_PREDICTABLE, > + emsg->addr); > if (IS_ERR(ifp)) > return; > brcmf_fws_add_interface(ifp); > -- > 1.9.3 > > -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/