Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757922AbaGOUF7 (ORCPT ); Tue, 15 Jul 2014 16:05:59 -0400 Received: from mail-qg0-f44.google.com ([209.85.192.44]:36098 "EHLO mail-qg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbaGOUFz (ORCPT ); Tue, 15 Jul 2014 16:05:55 -0400 MIME-Version: 1.0 In-Reply-To: <20140715150609.GA18174@kroah.com> References: <1405365333-17170-1-git-send-email-peter.senna@gmail.com> <1405365333-17170-4-git-send-email-peter.senna@gmail.com> <20140715150609.GA18174@kroah.com> Date: Tue, 15 Jul 2014 22:05:54 +0200 Message-ID: Subject: Re: [PATCH V4 4/6] staging: vt6556: Remove typedefs From: Peter Senna Tschudin To: Greg KH Cc: Forest Bond , Malcolm Priestley , devel@driverdev.osuosl.org, "linux-kernel@vger.kernel.org" , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 15, 2014 at 5:06 PM, Greg KH wrote: > On Mon, Jul 14, 2014 at 09:15:31PM +0200, Peter Senna Tschudin wrote: >> This patch removes uneeded typedefs reported by chackpatch and removes >> one enum. The removed enum from card.h: >> >> typedef enum _CARD_PHY_TYPE { >> PHY_TYPE_AUTO = 0, >> PHY_TYPE_11B, >> PHY_TYPE_11G, >> PHY_TYPE_11A >> } CARD_PHY_TYPE, *PCARD_PHY_TYPE; > > Why did you remove this? Unlike the other two enums this patch change, this one is not in use. As checkpatch complained about the typedef and it is not currently in use, I removed it. > -- Peter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/