Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755476AbaGOU7g (ORCPT ); Tue, 15 Jul 2014 16:59:36 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43973 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750990AbaGOU7d (ORCPT ); Tue, 15 Jul 2014 16:59:33 -0400 Date: Tue, 15 Jul 2014 13:59:32 -0700 From: Andrew Morton To: Richard Weinberger Cc: Fabian Frederick , LKML , Artem Bityutskiy , Adrian Hunter , "linux-mtd@lists.infradead.org" Subject: Re: [PATCH 1/1] fs/ubifs/super.c: replace seq_printf by seq_puts Message-Id: <20140715135932.879df4f901ac58338d387a35@linux-foundation.org> In-Reply-To: References: <1405452395-9296-1-git-send-email-fabf@skynet.be> X-Mailer: Sylpheed 3.2.0beta5 (GTK+ 2.24.10; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 15 Jul 2014 22:10:24 +0200 Richard Weinberger wrote: > On Tue, Jul 15, 2014 at 9:26 PM, Fabian Frederick wrote: > > Fix checkpatch warnings: > > "WARNING: Prefer seq_puts to seq_printf" > > Can you explain why seq_puts() is preferred over seq_printf()? - puts is presumably faster - puts doesn't go rogue if you accidentally pass it a "%". - this patch actually made fs/ubifs/super.o 12 bytes smaller. Perhaps because seq_printf() is a varargs function, forcing the caller to pass args on the stack instead of in registers. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/