Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760313AbaGPAo7 (ORCPT ); Tue, 15 Jul 2014 20:44:59 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46744 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756785AbaGPAoz (ORCPT ); Tue, 15 Jul 2014 20:44:55 -0400 X-Sasl-enc: ADfFyXkA6zwQOBFilRy+NteZKSQd+onM3UmBsQJ3ObYk 1405471494 Date: Tue, 15 Jul 2014 17:49:27 -0700 From: Greg KH To: Andrew Lutomirski Cc: Kamal Mostafa , "linux-kernel@vger.kernel.org" , stable , kernel-team@lists.ubuntu.com, "H. Peter Anvin" , Konrad Rzeszutek Wilk , Borislav Petkov , Linus Torvalds , Dirk Hohndel , Arjan van de Ven , comex , Alexander van Heukelum , Boris Ostrovsky Subject: Re: DO NOT APPLY: x86-64, espfix: Don't leak bits 31:16 of %esp returning to 16-bit stack Message-ID: <20140716004927.GB7279@kroah.com> References: <20140715235212.GC32651@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 15, 2014 at 04:56:36PM -0700, Andrew Lutomirski wrote: > On Tue, Jul 15, 2014 at 4:52 PM, Greg KH wrote: > > On Tue, Jul 15, 2014 at 04:21:46PM -0700, Andrew Lutomirski wrote: > >> On Tue, Jul 15, 2014 at 2:28 PM, Kamal Mostafa wrote: > >> > 3.13.11.5 -stable review patch. If anyone has any objections, please let me know. > >> > > >> > ------------------ > >> > > >> > From: "H. Peter Anvin" > >> > > >> > commit 3891a04aafd668686239349ea58f3314ea2af86b upstream. > >> > >> Do not apply to any -stable release yet. This causes nasty regressions on Xen. > > > > I thought you all found the Xen-regression-fix patch a few hours ago, > > right? > > That patch is insufficient: Xen guests still fail to initialize > espfix64 correctly on SMP. It's currently unclear that espfix64 can > work at all on Xen -- it's may be rather fundamentally incompatible > with the Xen hypercall IRET mechanism. So it might need to be > disabled entirely on Xen (and maybe Xen will fix the info leak in the > hypervisor). Ok, I'll pospone these all until the next round of stable releases next week, Linus's tree should be fixed by then. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/