Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758607AbaGPCQK (ORCPT <rfc822;w@1wt.eu>);
	Tue, 15 Jul 2014 22:16:10 -0400
Received: from mail-pa0-f48.google.com ([209.85.220.48]:49259 "EHLO
	mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753888AbaGPCQI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 15 Jul 2014 22:16:08 -0400
Date: Tue, 15 Jul 2014 19:16:06 -0700 (PDT)
Message-ID: <87mwcakpzw.wl%kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Zhang Rui <rui.zhang@intel.com>
Cc: Simon Horman <horms@verge.net.au>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Magnus Damm <magnus.damm@gmail.com>, devicetree@vger.kernel.org,
        linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
        Eduardo Valentin <eduardo.valentin@ti.com>, linux-pm@vger.kernel.org
Subject: Re: [PATCH 05/13] thermal: rcar: Document SoC-specific bindings
In-Reply-To: <1405435735.28592.50.camel@rzhang1-toshiba>
References: <1404908623-909-1-git-send-email-geert+renesas@glider.be>
	<1404908623-909-6-git-send-email-geert+renesas@glider.be>
	<20140711091358.GK12420@verge.net.au>
	<1405435735.28592.50.camel@rzhang1-toshiba>
User-Agent: Wanderlust/2.14.0 Emacs/23.3 Mule/6.0
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Hi

> > > The documentation only mentioned the generic fallback compatible property.
> > > Add the missing SoC-specific compatible properties, some of which are
> > > already in use.
> > > 
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > Cc: Zhang Rui <rui.zhang@intel.com>
> > > Cc: Eduardo Valentin <eduardo.valentin@ti.com>
> > > Cc: linux-pm@vger.kernel.org
> > 
> > Acked-by: Simon Horman <horms+renesas@verge.net.au>
> 
> Kuninori,
> 
> what' your opinion of this patch?
> 
> thanks,
> rui
> > 
> > > ---
> > >  .../devicetree/bindings/thermal/rcar-thermal.txt       | 18 ++++++++++++------
> > >  1 file changed, 12 insertions(+), 6 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > > index 28ef498a66e5..0ef00be44b01 100644
> > > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > > @@ -1,7 +1,13 @@
> > >  * Renesas R-Car Thermal
> > >  
> > >  Required properties:
> > > -- compatible		: "renesas,rcar-thermal"
> > > +- compatible		: "renesas,thermal-<soctype>", "renesas,rcar-thermal"
> > > +			  as fallback.
> > > +			  Examples with soctypes are:
> > > +			    - "renesas,thermal-r8a73a4" (R-Mobile AP6)
> > > +			    - "renesas,thermal-r8a7779" (R-Car H1)
> > > +			    - "renesas,thermal-r8a7790" (R-Car H2)
> > > +			    - "renesas,thermal-r8a7791" (R-Car M2)
> > >  - reg			: Address range of the thermal registers.
> > >  			  The 1st reg will be recognized as common register
> > >  			  if it has "interrupts".
> > > @@ -12,18 +18,18 @@ Option properties:
> > >  
> > >  Example (non interrupt support):
> > >  
> > > -thermal@e61f0100 {
> > > -	compatible = "renesas,rcar-thermal";
> > > -	reg = <0xe61f0100 0x38>;
> > > +thermal@ffc48000 {
> > > +	compatible = "renesas,thermal-r8a7779", "renesas,rcar-thermal";
> > > +	reg = <0xffc48000 0x38>;
> > >  };
> > >  
> > >  Example (interrupt support):
> > >  
> > >  thermal@e61f0000 {
> > > -	compatible = "renesas,rcar-thermal";
> > > +	compatible = "renesas,thermal-r8a73a4", "renesas,rcar-thermal";
> > >  	reg = <0xe61f0000 0x14
> > >  		0xe61f0100 0x38
> > >  		0xe61f0200 0x38
> > >  		0xe61f0300 0x38>;
> > > -	interrupts = <0 69 4>;
> > > +	interrupts = <0 69 IRQ_TYPE_LEVEL_HIGH>;
> > >  };

This patch and [12/13] are adding SoC-specific compatible name.
Of course we don't know future request,
and, adding SoC-specific compatible name for
fallbacking is nice safety for us.
So, I don't have strong objection about it.

But, thermal driver side do nothing for each
SoC-specific compatible name at this point.
This means

 -> There is no trouble in driver/SoC
 -> Add new (and not used) compatible name
 -> Nothing happen in driver/SoC

My questions are...
 1) How to verify this patch ?
 2) Do we need to update example SoC "specific name" list in rcar-thermal.txt.
    Few example codes are very enough ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/