Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964815AbaGPE2z (ORCPT ); Wed, 16 Jul 2014 00:28:55 -0400 Received: from mail-vc0-f179.google.com ([209.85.220.179]:37922 "EHLO mail-vc0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933959AbaGPE2w (ORCPT ); Wed, 16 Jul 2014 00:28:52 -0400 MIME-Version: 1.0 In-Reply-To: <1405484621.14773.22.camel@joe-AO725> References: <1405481937.14773.8.camel@joe-AO725> <1405484621.14773.22.camel@joe-AO725> Date: Wed, 16 Jul 2014 00:28:51 -0400 Message-ID: Subject: Re: Checkpatch Feature Idea: Search directory for files with errors and warnings with -d argument From: Nick Krause To: Joe Perches Cc: Andrew Morton , josh@joshtriplett.org, robh@kernel.org, florian.vaussard@epfl.ch, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 16, 2014 at 12:23 AM, Joe Perches wrote: > On Wed, 2014-07-16 at 00:16 -0400, Nick Krause wrote: >> On Tue, Jul 15, 2014 at 11:38 PM, Joe Perches wrote: >> > On Tue, 2014-07-15 at 22:50 -0400, Nick Krause wrote: >> >> I may have not found it myself but if it doesn't exist can we write a >> >> feature for checkpatch to be able to recursively >> >> search a directory structure with a -d aRrgument in order to make it >> >> easier to search larger directories for files that still >> >> need cleanup for files having kernel coding style issues. >> >linux-kernel@vger.kernel.org >> > xargs already works fine. >> > >> > git ls-files /*.[ch] | xargs ./scripts/checkpatch.pl -f >> > >> > I suggest you only use anything like this >> > on staging directories. >> > >> > >> >> Thanks Joe, >> That was what I needed to known :). I was hitting some errors in arch, >> so I will run that to see if there are any others. >> Cheers Nick > > I again suggest you _ONLY_ use checkpatch on staging. > > Doing checkpatch only cleanups will not make you a > better developer nor give you a good understanding > of the code operation. > I am cleaning up the kernel as it needs a lot of cleanup. In addition I am doing build related issues. Some developers removed me from FIX MES after several stupid patches I sent. If there is a area that needs help , please let me know :). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/