Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030457AbaGPHDP (ORCPT ); Wed, 16 Jul 2014 03:03:15 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:34420 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756658AbaGPHDN (ORCPT ); Wed, 16 Jul 2014 03:03:13 -0400 MIME-Version: 1.0 In-Reply-To: <4999408.jEEY9BVX9F@wuerfel> References: <1405413956-2772-1-git-send-email-lftan@altera.com> <1405413956-2772-23-git-send-email-lftan@altera.com> <4999408.jEEY9BVX9F@wuerfel> Date: Wed, 16 Jul 2014 15:03:12 +0800 X-Google-Sender-Auth: DyaZl5swaheguVR1EBIUTc30fpE Message-ID: Subject: Re: [PATCH v2 22/29] nios2: Miscellaneous header files From: Ley Foon Tan To: Arnd Bergmann Cc: Linux-Arch , "linux-kernel@vger.kernel.org" , "linux-doc@vger.kernel.org" , Chung-Lin Tang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 15, 2014 at 6:22 PM, Arnd Bergmann wrote: > On Tuesday 15 July 2014 16:45:49 Ley Foon Tan wrote: >> diff --git a/arch/nios2/include/asm/gpio.h b/arch/nios2/include/asm/gpio.h >> new file mode 100644 >> index 0000000..e726bfc >> --- /dev/null >> +++ b/arch/nios2/include/asm/gpio.h > This seems wrong. If any device drivers rely on this, better fix them to > use linux/gpio.h directly. Okay, will remove this file. >> +#ifndef __ASM_NIOS2_PCI_H__ >> +#define __ASM_NIOS2_PCI_H__ >> + >> +/* We don't support PCI yet, but some drivers require this file anyway */ >> + >> +#endif /* __ASM_NIOS2_PCI_H__ */ > > What's wrong with the generic version? Change to use generic pci.h. > >> +#ifndef _UAPI_ASM_NIOS2_STAT_H >> +#define _UAPI_ASM_NIOS2_STAT_H >> + >> +#include >> + >> +#endif > > This should just use the Kconfig logic to fall back on the generic file. Will use generic file. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/