Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760348AbaGPHyD (ORCPT ); Wed, 16 Jul 2014 03:54:03 -0400 Received: from mail-wg0-f46.google.com ([74.125.82.46]:61159 "EHLO mail-wg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753155AbaGPHyB (ORCPT ); Wed, 16 Jul 2014 03:54:01 -0400 Message-ID: <53C62F95.3020001@kernel.dk> Date: Wed, 16 Jul 2014 09:53:57 +0200 From: Jens Axboe User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Maurizio Lombardi , Mike Qiu CC: "linux-kernel@vger.kernel.org" , "ming.lei@canonical.com" , "dongsu.park@profitbricks.com" , "jet.chen@intel.com" , "viro@zeniv.linux.org.uk" , "hch@lst.de" , "kmo@daterainc.com" , "akpm@linux-foundation.org" , "axboe@fb.com" Subject: Re: Bug_ON with patch: bio: modify __bio_add_page() to accept pages that don't start a new segment References: <53C4E2F0.8000307@linux.vnet.ibm.com> <53C4E9F1.7070302@redhat.com> <53C620DD.7090700@redhat.com> In-Reply-To: <53C620DD.7090700@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2014-07-16 08:51, Maurizio Lombardi wrote: > Hi, > > On 07/15/2014 10:44 AM, Maurizio Lombardi wrote: >>> I have reverted it yesterday in my tree. >>> >> >> >> The problem was here: >> >> if (q->merge_bvec_fn) { >> struct bvec_merge_data bvm = { >> .bi_bdev = bio->bi_bdev, >> .bi_sector = bio->bi_iter.bi_sector, >> .bi_size = bio->bi_iter.bi_size, <------- >> .bi_rw = bio->bi_rw, >> }; >> >> /* >> * merge_bvec_fn() returns number of bytes it can accept >> * at this offset >> */ >> if (q->merge_bvec_fn(q, &bvm, bvec) < bvec->bv_len) >> goto failed; >> } >> >> /* If we may be able to merge these biovecs, force a recount */ >> if (bio->bi_vcnt > 1 && (BIOVEC_PHYS_MERGEABLE(bvec-1, bvec))) >> bio->bi_flags &= ~(1 << BIO_SEG_VALID); >> >> >> it should have been ".bi_size = bio->bi_iter.bi_size - len" >> > > Jens, will you restore the patch in your tree if I submit > this fix? Sure, we can try again, hopefully this will be the last of them. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/